fix: restore mouse-wheel scrolling in preview-as-text outputs#8863
Open
christian-byrne wants to merge 2 commits intomainfrom
Open
fix: restore mouse-wheel scrolling in preview-as-text outputs#8863christian-byrne wants to merge 2 commits intomainfrom
christian-byrne wants to merge 2 commits intomainfrom
Conversation
Remove `disabled` attribute from read-only preview textareas — disabled elements cannot receive focus, so the focus-gated wheel capture logic (#6597) always forwards wheel events to the canvas instead of allowing scroll. Add `data-capture-wheel` and `tabindex` to WidgetMarkdown display div so rendered markdown content can also capture wheel events when focused. Fixes COM-14812 Amp-Thread-ID: https://ampcode.com/threads/T-019c5a22-0e4c-7217-b022-49f9c86b8790
christian-byrne
added
the
verified bug
dosubot
bot
added
the
size:XS
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/14/2026, 09:00:21 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Playwright: ✅ 524 passed, 0 failed · 1 flaky 📊 Browser Reports
|
Contributor
📝 WalkthroughWalkthroughThree widget components are modified to enhance accessibility and interaction behavior: preview widgets are enabled by removing explicit disable directives, markdown widget rendering gains keyboard focus and wheel event capture capabilities, and textarea widget read-only state decoupling from disabled attributes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 21.7 kB (baseline 21.7 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 879 kB (baseline 879 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 68.9 kB (baseline 68.9 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 427 kB (baseline 427 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed User & Accounts — 16.1 kB (baseline 16.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 785 B (baseline 785 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 1 added / 1 removed UI Components — 36.6 kB (baseline 36.6 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed Utilities & Hooks — 237 kB (baseline 237 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed Vendor & Third-Party — 8.69 MB (baseline 8.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.31 MB (baseline 7.31 MB) • 🟢 -92 BBundles that do not match a named category
Status: 53 added / 53 removed |
christian-byrne
added
needs-backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore mouse-wheel scrolling for read-only preview widgets (PreviewAny plaintext and markdown modes), broken by the focus-gated wheel capture in #6597.
Changes
disabledattribute from read-only textareas (keepreadonly) so they can receive focus and capture wheel events. Adddata-capture-wheelandtabindexto WidgetMarkdown display div.disabledelements cannot receive focus in browsers. The focus-gatedwheelCapturedByFocusedElement()from Forward scroll unless focused #6597 always evaluated to false for disabled textareas, forwarding all wheel events to the canvas.Review Focus
disabledwhile keepingreadonlydoes not allow unintended editingtabindex="0"on the markdown display div does not cause unexpected tab-order issuesFixes COM-14812
┆Issue is synchronized with this Notion page by Unito