chore: enhance telemetry CI scan to detect Mixpanel and Impact#8872
Closed
comfy-pr-bot wants to merge 1 commit intomainfrom
Closed
chore: enhance telemetry CI scan to detect Mixpanel and Impact#8872comfy-pr-bot wants to merge 1 commit intomainfrom
comfy-pr-bot wants to merge 1 commit intomainfrom
Conversation
Expand the existing CI telemetry scan workflow to detect additional telemetry libraries beyond Google Tag Manager. Added detection patterns for: - Mixpanel (mixpanel-browser, api/cdn domains, init/track/identify methods) - Impact Analytics (impactcdn.com, tracking ID) Also improved error messaging to: - List all telemetry providers being checked - Provide troubleshooting guidance - Reference PR #8311 for historical context This prevents accidental inclusion of telemetry code in OSS builds, similar to the GTM incident in PR #8311. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/14/2026, 12:58:47 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
|
Playwright: ✅ 522 passed, 0 failed · 2 flaky 📊 Browser Reports
|
Contributor
📝 WalkthroughWalkthroughUpdates CI telemetry scan workflow to exclude additional Mixpanel-related patterns and improves output messaging by adding visual indicators (red cross and green checkmark) with detailed resolution guidance for telemetry findings. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 21.7 kB (baseline 21.7 kB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 879 kB (baseline 879 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 68.9 kB (baseline 68.9 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 427 kB (baseline 427 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
User & Accounts — 16.1 kB (baseline 16.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Editors & Dialogs — 785 B (baseline 785 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
UI Components — 36.6 kB (baseline 36.6 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 2.15 MB (baseline 2.15 MB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 237 kB (baseline 237 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 8.69 MB (baseline 8.69 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.31 MB (baseline 7.31 MB) • ⚪ 0 BBundles that do not match a named category
|
Contributor
|
Replaced by other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the existing CI telemetry scan workflow to detect additional telemetry libraries beyond Google Tag Manager (GTM).
Changes
Detection Patterns Added
Mixpanel:
mixpanel-browser- NPM package nameapi.mixpanel.com- API endpointcdn.mxpnl.com- CDN domainmixpanel.init- Initialization methodmixpanel.track- Event tracking methodmixpanel.identify- User identification methodmixpanel.people- People/user properties APIImpact Analytics:
impactcdn.com- CDN domainA6951770-3747-434a-9ac7-4e582e67d91f1- Tracking IDImproved Error Messages
Context
PR #8311 accidentally shipped GTM code to OSS builds. The current CI workflow only checked for GTM references. This enhancement adds comprehensive detection for Mixpanel and Impact Analytics to prevent similar incidents with other telemetry providers.
Testing
dist/🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito