Skip to content

feat: migrate auth forms to vee-validate #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DrJKL wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: migrate auth forms to vee-validate #9042

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ad4327
feat: migrate auth forms to vee-validate
DrJKL Feb 21, 2026
e39aa6a
fix: satisfy knip checks for vee-validate migration
DrJKL Feb 21, 2026
296cfce
fix: migrate to zod 4 and resolve peer warnings
DrJKL Feb 21, 2026
d63cea4
fix: address CodeRabbit review feedback
DrJKL Feb 21, 2026
d91a1e8
fix: upgrade vee-validate to v5 for native Zod 4 support
DrJKL Feb 21, 2026
68e3376
fix: clean up sign-in form tests and loading state
DrJKL Feb 21, 2026
b42c787
📝 Add docstrings to `drjkl/vee-validate`
coderabbitai[bot] Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion knip.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const config: KnipConfig = {
// Weird importmap things
'@iconify-json/lucide',
'@iconify/json',
'@primeuix/forms',
'@primeuix/styled',
'@primeuix/utils',
'@primevue/icons'
Expand Down
15 changes: 13 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,9 @@
"@comfyorg/shared-frontend-utils": "workspace:*",
"@comfyorg/tailwind-utils": "workspace:*",
"@iconify/json": "catalog:",
"@primeuix/forms": "catalog:",
"@primeuix/styled": "catalog:",
"@primeuix/utils": "catalog:",
"@primevue/core": "catalog:",
"@primevue/forms": "catalog:",
"@primevue/icons": "catalog:",
"@primevue/themes": "catalog:",
"@sentry/vue": "catalog:",
Expand Down Expand Up @@ -106,6 +104,7 @@
"three": "^0.170.0",
"tiptap-markdown": "^0.8.10",
"typegpu": "catalog:",
"vee-validate": "catalog:",
"vue": "catalog:",
"vue-i18n": "catalog:",
"vue-router": "catalog:",
Expand Down Expand Up @@ -194,6 +193,18 @@
"pnpm": {
"overrides": {
"vite": "catalog:"
},
"packageExtensions": {
"openai@4.104.0": {
"peerDependencies": {
"zod": "^3.23.8 || ^4.0.0"
}
}
},
"peerDependencyRules": {
"allowedVersions": {
"zod": "^4.0.0"
}
}
}
}
119 changes: 53 additions & 66 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,9 @@ catalog:
'@nx/vite': 22.2.6
'@pinia/testing': ^1.0.3
'@playwright/test': ^1.58.1
'@primeuix/forms': 0.0.2
'@primeuix/styled': 0.3.2
'@primeuix/utils': ^0.3.2
'@primevue/core': ^4.2.5
'@primevue/forms': ^4.2.5
'@primevue/icons': 4.2.5
'@primevue/themes': ^4.2.5
'@sentry/vite-plugin': ^4.6.0
Expand Down Expand Up @@ -93,6 +91,7 @@ catalog:
unplugin-icons: ^22.5.0
unplugin-typegpu: 0.8.0
unplugin-vue-components: ^30.0.0
vee-validate: ^4.15.1
vite: 8.0.0-beta.13
vite-plugin-dts: ^4.5.4
vite-plugin-html: ^3.2.2
Expand All @@ -107,9 +106,9 @@ catalog:
vuefire: ^3.2.1
wwobjloader2: ^6.2.1
yjs: ^13.6.27
zod: ^3.23.8
zod-to-json-schema: ^3.24.1
zod-validation-error: ^3.3.0
zod: ^4.3.6
zod-to-json-schema: ^3.25.1
zod-validation-error: ^5.0.0

cleanupUnusedCatalogs: true

Expand Down
Loading
Loading