Merged
Conversation
dosubot
bot
added
the
size:XS
|
Related Documentation Checked 0 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 02/21/2026, 08:06:39 AM UTC 🔗 Links🎨 Chromatic Visual Tests🎉 Your Storybook is ready for review! |
|
Playwright: ✅ 530 passed, 0 failed · 2 flaky 📊 Browser Reports
|
Contributor
📝 WalkthroughWalkthroughVersion bumped to 1.40.10 and multiple i18n locale files updated to add a new "Node Library" category, per-language "Comfy_NodeLibrary_NewDesign" setting (name + tooltip), and new node-favorite/unfavorite translation keys; small display_name tweaks for three English nodeDefs. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Bundle: 4.36 MB gzip 🔴 +1.15 kBDetailsSummary
Category Glance App Entry Points — 21.5 kB (baseline 21.5 kB) • 🔴 +1 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 926 kB (baseline 926 kB) • 🔴 +1 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 68.8 kB (baseline 68.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 436 kB (baseline 432 kB) • 🔴 +3.91 kBConfiguration panels, inspectors, and settings screens
Status: 21 added / 21 removed User & Accounts — 16 kB (baseline 16 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 738 B (baseline 738 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 1 added / 1 removed UI Components — 43.2 kB (baseline 43.2 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.5 MB (baseline 2.5 MB) • 🔴 +2 BStores, services, APIs, and repositories
Status: 13 added / 13 removed Utilities & Hooks — 57.7 kB (baseline 57.7 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed Vendor & Third-Party — 8.86 MB (baseline 8.86 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.6 MB (baseline 7.6 MB) • 🔴 +1.93 kBBundles that do not match a named category
Status: 62 added / 62 removed |
dosubot
bot
added
size:L
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/locales/pt-BR/main.json (1)
2366-2366: Auto-generated file — translation casing inconsistency is informational only.
settingsCategoriesnow contains two conceptually related keys with differing capitalisation in their pt-BR translations:
Key Translation "Node Library"(line 2366, new)"Biblioteca de nós""NodeLibrary"(line 2369, pre-existing)"Biblioteca de Nós"Since this file is auto-generated from the English source on every release, the discrepancy must be resolved in
src/locales/en/main.jsonor the generation pipeline — not here. No action needed in this PR.Based on learnings, locale files other than
src/locales/en/main.jsonare generated automatically on every release, so no manual edits to this file are required or recommended.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/locales/pt-BR/main.json` at line 2366, The pt-BR locale shows inconsistent capitalization between the keys "Node Library" ("Biblioteca de nós") and "NodeLibrary" ("Biblioteca de Nós"); since locale files are generated, update the English source so both keys use consistent casing (choose either "Node Library" or "NodeLibrary") and adjust the generation pipeline or en/main.json entry that defines these settingsCategories keys to produce a single consistent key/capitalization, then regenerate locales so translations are unified.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/locales/es/settings.json`:
- Around line 251-254: Update the tooltip string for the
"Comfy_NodeLibrary_NewDesign" locale entry so the tab names exactly match the UI
labels: change “Esencial, Todo, Personalizado” to “Esenciales, Todos los nodos,
Personalizado” in the tooltip value for Comfy_NodeLibrary_NewDesign so users see
consistent wording between the tooltip and the UI labels.
In `@src/locales/ru/settings.json`:
- Around line 251-254: The diff adds a manual translation entry for the locale
key "Comfy_NodeLibrary_NewDesign" in the Russian settings file which is
auto-generated and will be overwritten; remove this manual edit from the
non-English locale and instead ensure the new key/value is added only to the
English main locale (the en main file) so the translation generator can
propagate it, or confirm this change originates from the generator before
keeping it in the Russian file.
---
Duplicate comments:
In `@src/locales/fr/main.json`:
- Around line 2468-2470: The FR locale edits for keys "favoriteNode",
"favorites", and "unfavoriteNode" are duplicate/manual changes to a generated
file; revert/remove these manual edits in src/locales/fr/main.json and ensure
you only add new/updated i18n keys in src/locales/en/main.json (the generator
will propagate to other locales), and confirm these entries are present in the
English file or the generator outputs rather than committing changes to
generated locale files.
In `@src/locales/zh-TW/main.json`:
- Around line 2468-2470: The changes to the zh-TW locale keys ("favoriteNode",
"favorites", "unfavoriteNode" in src/locales/zh-TW/main.json) appear to be from
generated outputs and should not be manually edited; revert/remove manual edits
in zh-TW (and other non-en locale files) and instead add or update the
corresponding English keys/values in src/locales/en/main.json so the generator
can propagate translations, ensuring only src/locales/en/main.json is changed in
the PR.
---
Nitpick comments:
In `@src/locales/pt-BR/main.json`:
- Line 2366: The pt-BR locale shows inconsistent capitalization between the keys
"Node Library" ("Biblioteca de nós") and "NodeLibrary" ("Biblioteca de Nós");
since locale files are generated, update the English source so both keys use
consistent casing (choose either "Node Library" or "NodeLibrary") and adjust the
generation pipeline or en/main.json entry that defines these settingsCategories
keys to produce a single consistent key/capitalization, then regenerate locales
so translations are unified.
Comment on lines
+251
to
+254
| "Comfy_NodeLibrary_NewDesign": { | ||
| "name": "Nuevo diseño de la biblioteca de nodos", | ||
| "tooltip": "Activa la barra lateral rediseñada de la biblioteca de nodos con pestañas (Esencial, Todo, Personalizado), búsqueda mejorada y vistas previas al pasar el cursor." | ||
| }, |
Contributor
There was a problem hiding this comment.
Align tooltip tab names with the actual ES tab labels.
The tooltip mentions “Esencial, Todo, Personalizado”, while the UI labels are “Esenciales”, “Todos los nodos”, and “Personalizado”. Consider matching the exact labels to avoid confusion.
🛠️ Suggested wording alignment
- "tooltip": "Activa la barra lateral rediseñada de la biblioteca de nodos con pestañas (Esencial, Todo, Personalizado), búsqueda mejorada y vistas previas al pasar el cursor."
+ "tooltip": "Activa la barra lateral rediseñada de la biblioteca de nodos con pestañas (Esenciales, Todos los nodos, Personalizado), búsqueda mejorada y vistas previas al pasar el cursor."📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| "Comfy_NodeLibrary_NewDesign": { | |
| "name": "Nuevo diseño de la biblioteca de nodos", | |
| "tooltip": "Activa la barra lateral rediseñada de la biblioteca de nodos con pestañas (Esencial, Todo, Personalizado), búsqueda mejorada y vistas previas al pasar el cursor." | |
| }, | |
| "Comfy_NodeLibrary_NewDesign": { | |
| "name": "Nuevo diseño de la biblioteca de nodos", | |
| "tooltip": "Activa la barra lateral rediseñada de la biblioteca de nodos con pestañas (Esenciales, Todos los nodos, Personalizado), búsqueda mejorada y vistas previas al pasar el cursor." | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/locales/es/settings.json` around lines 251 - 254, Update the tooltip
string for the "Comfy_NodeLibrary_NewDesign" locale entry so the tab names
exactly match the UI labels: change “Esencial, Todo, Personalizado” to
“Esenciales, Todos los nodos, Personalizado” in the tooltip value for
Comfy_NodeLibrary_NewDesign so users see consistent wording between the tooltip
and the UI labels.
Comment on lines
+251
to
+254
| "Comfy_NodeLibrary_NewDesign": { | ||
| "name": "Новый дизайн библиотеки узлов", | ||
| "tooltip": "Включить обновлённую боковую панель библиотеки узлов с вкладками (Основные, Все, Пользовательские), улучшенным поиском и предварительным просмотром при наведении." | ||
| }, |
Contributor
There was a problem hiding this comment.
Avoid manual edits to generated locale files.
Line 251-254: Non-English locale files are auto-generated in this repo and manual edits here will be overwritten. Please confirm these updates come from the generator; otherwise keep only the English additions in src/locales/en/main.json.
Based on learnings: "In the Comfy-Org/ComfyUI_frontend repository, locale files other than src/locales/en/main.json are generated automatically on every release. Developers only need to add English (en) key/values in src/locales/en/main.json when making PRs; manual updates to other locale files (fr, ja, ko, ru, zh, zh-TW, es, ar, tr, etc.) are not required and should not be suggested in reviews."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/locales/ru/settings.json` around lines 251 - 254, The diff adds a manual
translation entry for the locale key "Comfy_NodeLibrary_NewDesign" in the
Russian settings file which is auto-generated and will be overwritten; remove
this manual edit from the non-English locale and instead ensure the new
key/value is added only to the English main locale (the en main file) so the
translation generator can propagate it, or confirm this change originates from
the generator before keeping it in the Russian file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch version increment to 1.40.10
Base branch:
main┆Issue is synchronized with this Notion page by Unito