feat: centralize link topology state and compatibility boundaries

browser_tests/tests/changeTracker.spec.ts

@@ -3,6 +3,7 @@
   comfyExpect as expect,
   comfyPageFixture as test
 } from '../fixtures/ComfyPage'
+import type { WorkspaceStore } from '../types/globals'
 
 async function beforeChange(comfyPage: ComfyPage) {
   await comfyPage.page.evaluate(() => {
@@ -63,6 +64,103 @@
       expect(await comfyPage.workflow.getUndoQueueSize()).toBe(0)
       expect(await comfyPage.workflow.getRedoQueueSize()).toBe(2)
     })
+
+    test('undo/redo restores link topology with reroutes and floating links', async ({
+      comfyPage
+    }) => {
+      await comfyPage.workflow.loadWorkflow('links/batch_move_links')
+
+      const readTopology = () =>
+        comfyPage.page.evaluate(() => {
+          const graph = window.app!.rootGraph
+          return {
+            links: graph.links.size,
+            floatingLinks: graph.floatingLinks.size,
+            reroutes: graph.reroutes.size,
+            serialised: graph.serialize()
+          }
+        })
+
+      const baseline = await readTopology()
+
+      await beforeChange(comfyPage)
+      await comfyPage.page.evaluate(() => {
+        const graph = window.app!.rootGraph
+        const firstLink = graph.links.values().next().value
+        if (!firstLink) throw new Error('Expected at least one link')
+
+        const reroute = graph.createReroute(
+          [firstLink.id * 5, firstLink.id * 3],
+          firstLink
+        )
+        graph.addFloatingLink(firstLink.toFloating('output', reroute.id))
+      })
+      await afterChange(comfyPage)
+
+      const mutated = await readTopology()
+      expect(mutated.floatingLinks).toBeGreaterThan(baseline.floatingLinks)
+      expect(mutated.reroutes).toBeGreaterThan(baseline.reroutes)
+      await expect.poll(() => comfyPage.workflow.getUndoQueueSize()).toBe(1)
+
+      await comfyPage.page.evaluate(async () => {
+        await (
+          window.app!.extensionManager as WorkspaceStore
+        ).workflow.activeWorkflow?.changeTracker.undo()
+      })
+      const afterUndo = await readTopology()
+      expect(afterUndo.links).toBe(baseline.links)
+      expect(afterUndo.floatingLinks).toBe(baseline.floatingLinks)
+      expect(afterUndo.reroutes).toBe(baseline.reroutes)
+      expect(afterUndo.serialised).toEqual(baseline.serialised)
+
+      await comfyPage.page.evaluate(async () => {
+        await (
+          window.app!.extensionManager as WorkspaceStore
+        ).workflow.activeWorkflow?.changeTracker.redo()
+      })
+      const afterRedo = await readTopology()
+      expect(afterRedo.links).toBe(mutated.links)
+      expect(afterRedo.floatingLinks).toBe(mutated.floatingLinks)
+      expect(afterRedo.reroutes).toBe(mutated.reroutes)
+      expect(afterRedo.serialised).toEqual(mutated.serialised)
+    })
+
+    test('read-through accessors stay in sync for links, floating links, and reroutes', async ({
+      comfyPage
+    }) => {
+      await comfyPage.workflow.loadWorkflow('links/batch_move_links')
+
+      const parity = await comfyPage.page.evaluate(() => {
+        const graph = window.app!.rootGraph
+        const firstLink = graph.links.values().next().value
+        if (!firstLink) throw new Error('Expected at least one link')
+
+        const reroute = graph.createReroute(
+          [firstLink.id * 7, firstLink.id * 4],
+          firstLink
+        )
+        const floatingLink = firstLink.toFloating('output', reroute.id)
+        graph.addFloatingLink(floatingLink)
+
+        return {
+          normalLinkMatches:
+            graph.getLink(firstLink.id) ===
+            graph.linkStore.getLink(firstLink.id),
+          floatingLinkRequiresExplicitProjection:
+            graph.getLink(floatingLink.id) !==
+              graph.linkStore.getFloatingLink(floatingLink.id) &&
+            graph.linkStore.getFloatingLink(floatingLink.id) ===
+              graph.floatingLinks.get(floatingLink.id),
+          rerouteMatches:
+            graph.getReroute(reroute.id) ===
+            graph.linkStore.getReroute(reroute.id)
+        }
+      })
+
+      expect(parity.normalLinkMatches).toBe(true)
+      expect(parity.floatingLinkRequiresExplicitProjection).toBe(true)
+      expect(parity.rerouteMatches).toBe(true)
+    })
   })
 
   test('Can group multiple change actions into a single transaction', async ({

browser_tests/tests/subgraph-rename-dialog.spec.ts

@@ -87,9 +87,9 @@ test.describe('Subgraph Slot Rename Dialog', { tag: '@subgraph' }, () => {
     // Get the current value in the prompt dialog
     const dialogValue = await comfyPage.page.inputValue(SELECTORS.promptDialog)
 
-    // This should show the current label (RENAMED_NAME), not the original name
+    // This should show the current renamed value and stay aligned with slot identity.
     expect(dialogValue).toBe(RENAMED_NAME)
-    expect(dialogValue).not.toBe(afterFirstRename.name) // Should not show the original slot.name
+    expect(dialogValue).toBe(afterFirstRename.name)
 
     // Complete the second rename to ensure everything still works
     await comfyPage.page.fill(SELECTORS.promptDialog, '')