[refactor] Rename queueIndex variables to reflect job.priority usage#9258
Merged
christian-byrne merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
dosubot
bot
added
the
size:S
🎨 Storybook: ✅ Built — View Storybook |
🎭 Playwright: ✅ 551 passed, 0 failed · 3 flaky📊 Browser Reports
|
Contributor
📝 WalkthroughWalkthroughVariables and computed properties named Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Bundle: 4.44 MB gzip 🔴 +172 BDetailsSummary
Category Glance App Entry Points — 17.9 kB (baseline 17.9 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.01 MB (baseline 1.01 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed Panels & Settings — 435 kB (baseline 435 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed User & Accounts — 16 kB (baseline 16 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed Editors & Dialogs — 736 B (baseline 736 B) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 1 added / 1 removed UI Components — 47.1 kB (baseline 47.1 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 2.55 MB (baseline 2.55 MB) • 🔴 +2 BStores, services, APIs, and repositories
Status: 13 added / 13 removed Utilities & Hooks — 55.5 kB (baseline 55.5 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 11 added / 11 removed Vendor & Third-Party — 8.84 MB (baseline 8.84 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 7.77 MB (baseline 7.77 MB) • ⚪ 0 BBundles that do not match a named category
Status: 52 added / 52 removed |
⚡ Performance Report
Raw data{
"timestamp": "2026-02-26T20:14:26.173Z",
"gitSha": "7a4feeef691c983314812a2486f52b23f346aef5",
"branch": "fix/rename-queue-index-to-job-priority",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2007.4489999999798,
"styleRecalcs": 123,
"styleRecalcDurationMs": 20.755000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.158,
"heapDeltaBytes": -1977304
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2046.9119999999918,
"styleRecalcs": 182,
"styleRecalcDurationMs": 53.897999999999996,
"layouts": 12,
"layoutDurationMs": 3.6119999999999997,
"taskDurationMs": 1037.5829999999999,
"heapDeltaBytes": -2320468
},
{
"name": "dom-widget-clipping",
"durationMs": 564.7599999999784,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.722999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357,
"heapDeltaBytes": 6431268
}
]
} |
christian-byrne
pushed a commit
that referenced
this pull request
Feb 27, 2026
…9258) ## Summary Rename `lastHistoryQueueIndex` → `lastJobHistoryPriority` and `currentQueueIndex` → `currentJobPriority` to reflect that these variables now read `job.priority` directly. ## Changes - **queueStore.ts**: `lastHistoryQueueIndex` → `lastJobHistoryPriority` - **JobDetailsPopover.vue**: `currentQueueIndex` → `currentJobPriority` - **queueStore.test.ts**: Updated references and test descriptions Fixes #9246 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9258-refactor-Rename-queueIndex-variables-to-reflect-job-priority-usage-3136d73d36508126989dd464f7dad9a1) by [Unito](https://www.unito.io)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
lastHistoryQueueIndex→lastJobHistoryPriorityandcurrentQueueIndex→currentJobPriorityto reflect that these variables now readjob.prioritydirectly.Changes
lastHistoryQueueIndex→lastJobHistoryPrioritycurrentQueueIndex→currentJobPriorityFixes #9246
┆Issue is synchronized with this Notion page by Unito