Skip to content

Conversation

@robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Dec 29, 2024

Previously, we checked gitignore for files that should not be published. However, some .gitignores were out of sync with files that are already tracked by git. Simplify the implementation by calling git ls-files

@robinjhuang
Copy link
Member Author

Suggestion by @webfiltered , we can use git ls-files

@robinjhuang robinjhuang changed the title Disregard .gitignore in node publishing in CI environments [Registry] Publish all files tracked by git Dec 31, 2024
@robinjhuang robinjhuang merged commit 2d05545 into main Dec 31, 2024
12 checks passed
@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants