Skip to content

Simplify function calls for enabling/disabling tracking. #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinjhuang merged 1 commit into from
Feb 25, 2025
+2 −7
Merged

Simplify function calls for enabling/disabling tracking. #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions comfy_cli/tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@

@app.command()
def enable():
set_tracking_enabled(True)
init_tracking(True)

Check warning on line 33 in comfy_cli/tracking.py

View check run for this annotation

Codecov / codecov/patch

comfy_cli/tracking.py#L33 

Added line #L33 was not covered by tests
typer.echo(f"Tracking is now {'enabled'}.")
init_tracking(True)


@app.command()
def disable():
set_tracking_enabled(False)
init_tracking(False)

Check warning on line 40 in comfy_cli/tracking.py

View check run for this annotation

Codecov / codecov/patch

comfy_cli/tracking.py#L40 

Added line #L40 was not covered by tests
typer.echo(f"Tracking is now {'disabled'}.")


Expand Down Expand Up @@ -116,8 +116,3 @@
logging.debug("Tracking install event.")
config_manager.set(constants.CONFIG_KEY_INSTALL_EVENT_TRIGGERED, "True")
track_event("install")


def set_tracking_enabled(enabled: bool):
config_manager.set(constants.CONFIG_KEY_ENABLE_TRACKING, str(enabled))
return enabled
Loading