Skip to content

Conversation

@jimlee2048
Copy link
Contributor

@jimlee2048 jimlee2048 commented Mar 1, 2025

ComfyUI-Manager now suggests to install in lowercase folder name (also its registry node name).
CleanShot 2025-03-01 at 15 06 45@2x

However, the current logic only use the name ComfyUI-Manager to get path, which would ignores the lowercase name comfyui-manager in case-sensitive filesystems.

In addition, I changed the default ComfyUI-Manager installation path to use lowercase folder names as suggested in its README.md.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 1, 2025
@codecov
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/workspace_manager.py 0.00% 9 Missing ⚠️
comfy_cli/command/custom_nodes/command.py 0.00% 5 Missing ⚠️
comfy_cli/command/custom_nodes/cm_cli_util.py 0.00% 3 Missing ⚠️
comfy_cli/command/install.py 0.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##             main     #244      +/-   ##
==========================================
- Coverage   44.78%   44.61%   -0.18%     
==========================================
  Files          29       29              
  Lines        2838     2849      +11     
==========================================
  Hits         1271     1271              
- Misses       1567     1578      +11     
Files with missing lines Coverage Δ
comfy_cli/command/install.py 32.84% <0.00%> (ø)
comfy_cli/command/custom_nodes/cm_cli_util.py 25.49% <0.00%> (-0.51%) ⬇️
comfy_cli/command/custom_nodes/command.py 37.73% <0.00%> (-0.42%) ⬇️
comfy_cli/workspace_manager.py 54.11% <0.00%> (-1.98%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the bug Something isn't working label Mar 1, 2025
@polarathene
Copy link

Related: #233

@jimlee2048
Copy link
Contributor Author

close stale pr

@jimlee2048 jimlee2048 closed this Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants