Skip to content

fix(sno-allow-customize-registry-api-url): read env #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snomiao wants to merge 3 commits into from
Closed

fix(sno-allow-customize-registry-api-url): read env #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9b1bc9
fix(sno-allow-customize-registry-api-url): read env
snomiao Mar 6, 2025
d17bfb5
Refactor environment variable mocks in test cases for base URL determ…
snomiao Jul 12, 2025
728d3c4
Add test for custom registry base URL determination
snomiao Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions comfy_cli/registry/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ def __init__(self):
self.base_url = self.determine_base_url()

def determine_base_url(self):
COMFY_REGISTRY_API = os.getenv("COMFY_REGISTRY_API", None)
if COMFY_REGISTRY_API is not None:
return COMFY_REGISTRY_API

env = os.getenv("ENVIRONMENT")
if env == "dev":
return "http://localhost:8080"
Expand Down
9 changes: 7 additions & 2 deletions tests/comfy_cli/registry/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,19 @@ def setUp(self):

@patch("os.getenv")
def test_determine_base_url_dev(self, mock_getenv):
mock_getenv.return_value = "dev"
mock_getenv.side_effect = lambda key, default=None: "dev" if key == "ENVIRONMENT" else default
self.assertEqual(self.registry_api.determine_base_url(), "http://localhost:8080")

@patch("os.getenv")
def test_determine_base_url_prod(self, mock_getenv):
mock_getenv.return_value = "prod"
mock_getenv.side_effect = lambda key, default=None: "prod" if key == "ENVIRONMENT" else default
self.assertEqual(self.registry_api.determine_base_url(), "https://api.comfy.org")

@patch("os.getenv")
def test_determine_base_url_custom_registry(self, mock_getenv):
mock_getenv.side_effect = lambda key, default=None: "https://custom.registry.com" if key == "COMFY_REGISTRY_API" else default
self.assertEqual(self.registry_api.determine_base_url(), "https://custom.registry.com")

@patch("requests.post")
def test_publish_node_version_success(self, mock_post):
mock_response = MagicMock()
Expand Down
Loading