Skip to content

Conversation

@jtydhr88
Copy link
Collaborator

Added a parameter in pyproject.toml, includes = [], which contains folder paths, for example includes = ['/js', '/dist'].
The purpose of doing this is, in certain situations, such as after packaging through npm, the output directory might be added to gitignore, but when publishing to the registry, It should be included.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels May 16, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 16, 2025
@robinjhuang
Copy link
Member

LGTM!

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 18, 2025
@codecov
Copy link

codecov bot commented May 18, 2025

Codecov Report

Attention: Patch coverage is 13.95349% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/file_utils.py 3.03% 32 Missing ⚠️
comfy_cli/command/custom_nodes/command.py 50.00% 4 Missing ⚠️
comfy_cli/registry/config_parser.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 44.51% <13.95%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/registry/types.py 100.00% <100.00%> (ø)
comfy_cli/registry/config_parser.py 27.72% <0.00%> (-0.28%) ⬇️
comfy_cli/command/custom_nodes/command.py 38.33% <50.00%> (+0.19%) ⬆️
comfy_cli/file_utils.py 55.66% <3.03%> (-11.39%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtydhr88 jtydhr88 changed the title add new parameter includes Added: publish all files in includes field in pyproject.toml May 21, 2025
@jtydhr88 jtydhr88 merged commit d9d4248 into Comfy-Org:main May 21, 2025
9 of 11 checks passed
@jtydhr88 jtydhr88 deleted the new-paramter-includes branch May 21, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants