Skip to content

feat: support --exit-on-fail for comfy node install command #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bigcat88 merged 2 commits into from
Jul 27, 2025
Merged

feat: support --exit-on-fail for comfy node install command #275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9362665
feat: support `--exit-on-fail` for `comfy node install` command
ltdrdata May 18, 2025
59e7c1a
Merge branch 'main' into dr-exit-on-fail
ltdrdata Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion comfy_cli/command/custom_nodes/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,13 @@ def install(
help="Use new fast dependency installer",
),
] = False,
exit_on_fail: Annotated[
bool,
typer.Option(
"--exit-on-fail",
help="Exit on failure",
),
] = False,
mode: str = typer.Option(
None,
help="[remote|local|cache]",
Expand All @@ -413,7 +420,12 @@ def install(

validate_mode(mode)

execute_cm_cli(["install"] + nodes, channel=channel, fast_deps=fast_deps, mode=mode)
if exit_on_fail:
cmd = ["install", "--exit-on-fail"] + nodes
else:
cmd = ["install"] + nodes

execute_cm_cli(cmd, channel=channel, fast_deps=fast_deps, mode=mode)


@app.command(help="Reinstall custom nodes")
Expand Down
Loading