Skip to content

Fix Windows Unicode error in node commands #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robinjhuang merged 2 commits into from
May 29, 2025
Merged

Fix Windows Unicode error in node commands #277

robinjhuang merged 2 commits into from
May 29, 2025

Conversation

@robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented May 29, 2025

Summary

  • Fixes UnicodeDecodeError when running comfy node show all on Windows
  • Adds explicit UTF-8 encoding with error handling to subprocess calls in ComfyUI-Manager integration

Test plan

  • Verify Windows e2e tests pass for test_node function
  • Test comfy node show all command on Windows environment
  • Ensure other node commands continue to work correctly

🤖 Generated with Claude Code

@robinjhuang @claude
Fix Windows Unicode error in node commands
7e02d25 
Fixes UnicodeDecodeError when running `comfy node show all` on Windows by explicitly setting UTF-8 encoding with error handling for subprocess calls to ComfyUI-Manager.

The error occurred because Windows defaults to cp1252 encoding which cannot decode certain Unicode characters (byte 0x9d) output by ComfyUI-Manager scripts.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels May 29, 2025
@codecov
Copy link

codecov bot commented May 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/custom_nodes/cm_cli_util.py 0.00% 1 Missing ⚠️
Flag Coverage Δ
unittests 44.51% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/command/custom_nodes/cm_cli_util.py 26.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robinjhuang robinjhuang merged commit 2e36f33 into main May 29, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robinjhuang