-
Notifications
You must be signed in to change notification settings - Fork 101
Send additional metadata to registry service during node creation #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
47a9563 to
7c2cdaf
Compare
7c2cdaf to
2e36f33
Compare
92199a0 to
137bbb6
Compare
|
Just FYI, once we added any new properties in pyproject specifications, we also need to update in core as well, see Comfy-Org/ComfyUI#8357 |
a249961 to
e54cb2c
Compare
e54cb2c to
401d252
Compare
0cd975c to
5715763
Compare
|
LGTM. Good to merge after confirming that this was testing publishing to staging. |
6aeace3 to
26ad1b0
Compare
|
Tested with latest staging changes: pyproject.toml file: |
26ad1b0 to
c4370bc
Compare
|
@coderfromthenorth93 @robinjhuang do you think we need to add supported_comfyui_manager_version as metadata? because I know some custom nodes are using the api of ComfyUI Manager? |
|
BTW as I mentioned, for any new metadata in types, it should be synced to Core types https://github.com/comfyanonymous/ComfyUI/blob/master/comfy_config/types.py |
Parse the toml file and send the following fields from pyproject.toml to backend when publishing a node:
supported_os- extracted from fields which have aOperation System ::prefix in classifierssupported_accelerators- extracted from fields which have aEnvironment ::prefix in classifierssupported_comfyui_version- extracted fromrequires-comfyuitoolssupported_comfyui_frontend_version- extracted fromcomfyui-frontend-packageindependencies(this is stripped fromdependenciesarray which is sent to the registryResolves #273