Skip to content

Parse banner url from toml file and send it to registry service while… #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coderfromthenorth93 merged 1 commit into from
Jun 10, 2025
Merged

Parse banner url from toml file and send it to registry service while… #283

coderfromthenorth93 merged 1 commit into from
Jun 10, 2025

Conversation

@coderfromthenorth93
Copy link
Contributor

@coderfromthenorth93 coderfromthenorth93 commented Jun 9, 2025 •
edited
Loading

  • Parse Banner from tool.comfy section of pyproject.toml file

@codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 45.55% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/registry/api.py 89.65% <ø> (ø)
comfy_cli/registry/config_parser.py 51.70% <ø> (ø)
comfy_cli/registry/types.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfromthenorth93 coderfromthenorth93 force-pushed the node-banner-url branch 2 times, most recently from 377dd7c to 5653a28 Compare June 9, 2025 23:30
@coderfromthenorth93 coderfromthenorth93 marked this pull request as ready for review June 9, 2025 23:39
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels Jun 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2025
@coderfromthenorth93 coderfromthenorth93 merged commit d1944c5 into main Jun 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robinjhuang robinjhuang robinjhuang approved these changes

@james00012 james00012 Awaiting requested review from james00012

Assignees

No one assigned

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coderfromthenorth93 @robinjhuang