-
Notifications
You must be signed in to change notification settings - Fork 100
add PR support #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add PR support #287
Conversation
Codecov ReportAttention: Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strengths
- Excellent test coverage (376 lines of tests)
- Clean separation of concerns
- Good error handling with rich formatting
- Handles both fork and same-repo PRs correctly
Possible Improvements
Critical:
- Parameter validation bug (cmdline.py:348): The condition
version != "nightly" or commitwill be true if version is None, preventing valid use cases. Should beversion not in {None, "nightly"} or commit.
Important:
- Timestamp formatting (install.py:381): The reset_time is displayed as a Unix timestamp instead of human-readable format.
- Deleted fork handling (install.py:579): Missing null check will cause KeyError if PR is from a deleted fork.
- Branch name sanitization (git_utils.py:87): Git will reject branch names with special characters.
Suggestions:
- Docstring placement (install.py:184): Move docstring before code execution.
- Remote naming (git_utils.py:70): Consider using
pr-{number}-{user}to avoid conflicts when checking out multiple PRs from same author.
|
@christian-byrne fixed your feedback except Timestamp formatting, this is an existing code used in checkout version, I just move it into a function could be shared in my new logic |
|
btw, regarding to failing test, I checked it and likely failed on download something on the MAC machine, not caused by my changes I believe |
bounty task https://www.notion.so/drip-art/Add-Comfy-CLI-feature-to-check-out-a-single-PR-launch-comfy-and-run-a-set-of-tests-1f36d73d36508074b1c3fc56d13f4346?source=copy_link
add --pr arg, support format:
"username:branch-name""#123""https://github.com/comfyanonymous/ComfyUI/pull/123"full command:
comfy --workspace=G:\comfy-cli-test install --pr "https://github.com/comfyanonymous/ComfyUI/pull/8597"then
comfy --workspace=G:\comfy-cli-test launch