fix: use constants in ConfigManager #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted this issue while looking at some recent changes.
Fixes ConfigManager to always use the defined constants, so that it won't break if the constant values are changed in the future.
I also ripgrep'd the rest of the codebase and did not come up with any other locations where the strings are used instead of the constants, so it seems fine now.
I was unsure about this location though:
comfy-cli/comfy_cli/workspace_manager.py
Lines 135 to 139 in 6be00e4
It doesn't seem like it should be using
CONTEXT_KEY_RECENT = "recent"instead of hardcoding. Perhaps someone can confirm that the workspace manager keys are indeed totally separate from the config keys.