Skip to content

Conversation

@bigcat88
Copy link
Contributor

@bigcat88 bigcat88 commented Sep 4, 2025

Addition to #314

Correct handling of the FileNotFoundError error with information about a specific failure displayed on the screen.

Also added information about the exact version of node/npm/pnpn used.

Screenshot from 2025-09-04 18-19-09 Screenshot from 2025-09-04 18-20-02

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 4, 2025
@codecov
Copy link

codecov bot commented Sep 4, 2025

Codecov Report

❌ Patch coverage is 72.05882% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/command/install.py 72.05% 19 Missing ⚠️
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   50.63%   50.61%   -0.02%     
==========================================
  Files          32       32              
  Lines        3405     3432      +27     
==========================================
+ Hits         1724     1737      +13     
- Misses       1681     1695      +14     
Files with missing lines Coverage Δ
comfy_cli/command/install.py 57.67% <72.05%> (-0.60%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the bug Something isn't working label Sep 4, 2025
@bigcat88 bigcat88 requested review from christian-byrne and removed request for christian-byrne September 4, 2025 15:20
@bigcat88 bigcat88 merged commit d50e501 into main Sep 6, 2025
15 checks passed
@bigcat88 bigcat88 deleted the fix/pnpm-detection branch September 6, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants