Add .comfyignore support to node packaging#321
Conversation
- Introduced .comfyignore file to exclude files from packaging - Updated zip_files function to respect .comfyignore patterns - Added tests to validate .comfyignore functionality
|
Hello. Can you please fix the linter error and failing test? |
- Simplify type hints in file_utils.py by replacing List with built-in list - Update file reading logic in _load_comfyignore_spec for clarity - Introduce new test suite for file_utils, covering various scenarios - Enhance requirements.compiled with additional comments for clarity
Done |
- Enhance test_compile to filter out optional dependencies 🧪
|
Used Properly, the .comfyignore should really benefit the community, node devs can publish lightweight nodes while keeping all the dev noise aside without having to .gitignore any dev files. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 50.87% 52.00% +1.12%
==========================================
Files 32 32
Lines 3444 3500 +56
==========================================
+ Hits 1752 1820 +68
+ Misses 1692 1680 -12
🚀 New features to boost your workflow:
|
|
@bigcat88 should I update the README ? |
There was a problem hiding this comment.
There is no need to update the main readme yet; the information in README_DEV is sufficient for now.
Should we update text here?
@app.command(
"pack",
help="Pack the current node into a zip file. Ignorining .gitignore files.",
)
@tracking.track_command("pack")Is it possible to move test to the tests folder? (I can do it myself later in a separate PR)
I looked at the code, and overall I agree that it's a useful thing, and I can say in advance that we're ready to accept this PR after some minor clarifications.
- Add tests for zip_files function to ensure .comfyignore compliance 🧪
|
Thanks for the careful read, to answer your questions and inquiries I did the following: • Updated the pack command help text so it now says “honoring .comfyignore patterns,” and cleaned up the typo. Happy to expand or add more docs if you’d like! |
|
Important to note: |
bigcat88
left a comment
There was a problem hiding this comment.
Thank you for the detailed answers and for making this PR so easy to review. Everything looks great, and we are ready to merge it, if you are agree.
We plan to hold this in the main branch for about a week before cutting a new release. This will give users who build from source a chance to test it and ensure everything is stable.
|
Most welcome, Sure go ahead and merge. |
Summary
.comfyignoreTesting
pytest