Improve npm not found error messages with OS-specific guidance #354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When npm is missing but Node.js is present, users now see detailed, step-by-step instructions tailored to their operating system: - Windows: Uninstall/reinstall steps via Add/Remove Programs - macOS: Direct download or Homebrew options - Linux: apt install npm or NodeSource repository setup Each guide includes verification steps so non-technical users can confirm the fix worked before re-running their command.
dosubot
bot
added
size:M
bigcat88
approved these changes
Jan 20, 2026
Contributor
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
Failure in CI is not related to PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When npm is missing but Node.js is present, the current error message just says "npm usually comes with Node.js. Try reinstalling Node.js" — not enough detail for non-technical users.
Solution
Added
_print_npm_not_found_help()that provides detailed, OS-specific step-by-step instructions:apt install npmor NodeSource repository setupEach guide includes:
Testing
All existing tests pass (
pytest tests/comfy_cli/command/test_frontend_pr.py).