Skip to content

Conversation

@bigcat88
Copy link
Contributor

This PR is based on the this one: #356

Fixes #355

PR #349 changed Optional[bool] type hints to bool | None syntax, but typer < 0.12.4 does not support PEP 604 union types, causing RuntimeError: Type not yet supported: bool | None.

Changes:

  • Update typer dependency from >=0.9 to >=0.12.5 (adds PEP 604 support via typer#548)
  • Remove deprecated is_flag parameter from typer.Option() calls (deprecated in typer 0.15.0, never worked properly)

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Jan 24, 2026
@bigcat88 bigcat88 changed the title chore: set minimal supported Typer version to 0.12.5 fix: update typer to >=0.12.5 for PEP 604 union type support Jan 24, 2026
@socket-security
Copy link

socket-security bot commented Jan 24, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtyper@​0.16.0 ⏵ 0.21.199 +1100100100100

View full report

The mix_stderr parameter was removed in modern click/typer.
Use result.output instead of result.stdout + result.stderr.
Modern typer handles prompts differently, causing tracking consent
prompts to fail in CI. Add autouse fixture to mock the prompt.
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 24, 2026
@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   51.93%   51.33%   -0.61%     
==========================================
  Files          32       32              
  Lines        3489     3563      +74     
==========================================
+ Hits         1812     1829      +17     
- Misses       1677     1734      +57     
Files with missing lines Coverage Δ
comfy_cli/cmdline.py 49.39% <ø> (ø)
comfy_cli/command/custom_nodes/command.py 43.19% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 merged commit bc0d87f into main Jan 24, 2026
13 of 14 checks passed
@bigcat88 bigcat88 deleted the chore/dependency/typer branch January 24, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR #349 breaks typer compatibility: RuntimeError with 'bool | None' type hints

1 participant