Skip to content

Fixed: User gets stuck in Desktop Updating page when error occurs #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinjhuang merged 2 commits into from
Mar 13, 2025
Merged

Fixed: User gets stuck in Desktop Updating page when error occurs #1055

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7533a3f
Show error page when installation has an error.
robinjhuang Mar 12, 2025
3441ac8
Just load server start.
robinjhuang Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/install/installationManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,9 +285,14 @@ export class InstallationManager implements HasTelemetry {
onStdout: sendLogIpc,
onStderr: sendLogIpc,
};
await installation.virtualEnvironment.installComfyUIRequirements(callbacks);
await installation.virtualEnvironment.installComfyUIManagerRequirements(callbacks);
await installation.validate();
try {
await installation.virtualEnvironment.installComfyUIRequirements(callbacks);
await installation.virtualEnvironment.installComfyUIManagerRequirements(callbacks);
await installation.validate();
} catch (error) {
log.error('Error auto-updating packages:', error);
await this.appWindow.loadPage('server-start');
}
}

static setReinstallHandler(installation: ComfyInstallation) {
Expand Down
Loading