Skip to content

Install Path Validation Improvements #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
robinjhuang merged 9 commits into from
Mar 17, 2025
Merged

Install Path Validation Improvements #1059

robinjhuang merged 9 commits into from
Mar 17, 2025

Conversation

@robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Mar 14, 2025 •
edited
Loading

  • Have separate requirements for free space for mac and Windows (5gb vs 10gb)
  • Replace OneDrive in the default install path for Windows
  • Validate install path does not contain OneDrive
  • Validate install path does not contain a non system drive (eg. Must be C:\ drive)

FE PR here: Comfy-Org/ComfyUI_frontend#3059

┆Issue is synchronized with this Notion page by Unito

@robinjhuang robinjhuang requested review from a team as code owners March 14, 2025 23:37
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 14, 2025
@robinjhuang robinjhuang mentioned this pull request Mar 14, 2025
Merged
@robinjhuang robinjhuang requested a review from webfiltered March 16, 2025 03:24
webfiltered
webfiltered reviewed Mar 16, 2025
View reviewed changes
@robinjhuang robinjhuang requested a review from webfiltered March 17, 2025 19:04
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 17, 2025
@robinjhuang robinjhuang merged commit b4708c5 into main Mar 17, 2025
6 checks passed
@robinjhuang robinjhuang deleted the rh-path branch March 17, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@webfiltered webfiltered webfiltered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robinjhuang @webfiltered