Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Dec 24, 2025

Bump the bundled ComfyUI core to v0.6.0.

What changed

  • Updated the bundled ComfyUI core version and the requirements patch to the v0.6.0 workflow templates.
  • Regenerated the macOS and Windows compiled requirements to align with the v0.6.0 dependency set (including comfyui-manager 4.0.3b7).

Why

  • Keep the desktop bundle aligned with the latest stable ComfyUI core release so users get upstream fixes and updates.
  • Regenerate platform lockfiles directly from the upstream v0.6.0 requirements to keep dependency resolution consistent.
  • Tradeoffs: still uses the existing frontend version; follow-ups may be needed if future core releases add new optional deps.

Evidence

  • Tests: yarn format, yarn lint, yarn typescript

References

┆Issue is synchronized with this Notion page by Unito

Copilot AI review requested due to automatic review settings December 24, 2025 02:45
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 24, 2025

📝 Walkthrough

Walkthrough

This PR updates dependency versions across platform-specific compiled requirements files (macOS, Windows CPU, Windows NVIDIA) by bumping comfyui-manager, comfyui-workflow-templates, and related media/core packages, along with a ComfyUI version increment in package.json from 0.5.0 to 0.6.0 and removal of a deprecated frontend dependency.

Changes

Cohort / File(s) Summary
Platform-specific compiled requirements
assets/requirements/macos.compiled, assets/requirements/windows_cpu.compiled, assets/requirements/windows_nvidia.compiled
Synchronized version bumps across all three platform files: comfyui-manager (4.0.3b5→4.0.3b7), comfyui-workflow-templates (0.7.59→0.7.63), comfyui-workflow-templates-core (0.3.43→0.3.58), comfyui-workflow-templates-media-api (0.3.22→0.3.31), comfyui-workflow-templates-media-image (0.3.36→0.3.43), comfyui-workflow-templates-media-other (0.3.47→0.3.61), comfyui-workflow-templates-media-video (0.3.19→0.3.22)
Core requirements patch
scripts/core-requirements.patch
Removed deprecated comfyui-frontend-package dependency; updated comfyui-workflow-templates from 0.7.59 to 0.7.63
Project configuration
package.json
Bumped config.comfyUI.version from 0.5.0 to 0.6.0

Possibly related PRs

  • Update ComfyUI core to v0.5.0 #1488: Continues the same dependency-version updates for ComfyUI manager and workflow-templates packages across requirement files.
  • Bump to v0.6.1 #1489: Directly modifies package.json's comfyUI version field (bumps to 0.6.1), overlapping with this PR's config change.
  • Update ComfyUI core to v0.4.0 #1466: Makes overlapping changes to the same dependency pins in assets/requirements/* files and package.json comfyUI version configuration.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump/comfyui-0.6.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the bundled ComfyUI core from version 0.5.0 to 0.6.0, along with associated dependency updates to align with the v0.6.0 release. The update includes the workflow templates package (0.7.59 → 0.7.63), comfyui-manager (4.0.3b5 → 4.0.3b7), and their transitive dependencies across all platform-specific compiled requirements files.

Key Changes:

  • ComfyUI core version bumped from 0.5.0 to 0.6.0 in package.json
  • Workflow templates updated from 0.7.59 to 0.7.63 with related sub-package updates
  • Platform-specific requirements regenerated for Windows (NVIDIA), Windows (CPU), and macOS

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated ComfyUI core version from 0.5.0 to 0.6.0
scripts/core-requirements.patch Updated patch to reflect v0.6.0 workflow templates dependency
assets/requirements/windows_nvidia.compiled Regenerated Windows NVIDIA requirements with updated package versions
assets/requirements/windows_cpu.compiled Regenerated Windows CPU requirements with updated package versions
assets/requirements/macos.compiled Regenerated macOS requirements with updated package versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,4 +1,3 @@
-comfyui-frontend-package==1.34.9
comfyui-workflow-templates==0.7.59
comfyui-workflow-templates==0.7.63
Copy link

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch file appears to be inconsistent. Line 6 shows comfyui-workflow-templates==0.7.63 with a space prefix (indicating an unchanged context line), but according to the PR description and the diff, this line should reflect an update from version 0.7.59 to 0.7.63.

A proper patch file should show this as:

-comfyui-workflow-templates==0.7.59
+comfyui-workflow-templates==0.7.63

This may cause the patch to fail when applied if the actual requirements.txt file still contains version 0.7.59.

Suggested change
comfyui-workflow-templates==0.7.63
-comfyui-workflow-templates==0.7.59
+comfyui-workflow-templates==0.7.63

Copilot uses AI. Check for mistakes.
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 070224f and be9f3d1.

📒 Files selected for processing (5)
  • assets/requirements/macos.compiled
  • assets/requirements/windows_cpu.compiled
  • assets/requirements/windows_nvidia.compiled
  • package.json
  • scripts/core-requirements.patch
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Agent
  • GitHub Check: lint-and-format (macos-latest)
  • GitHub Check: lint-and-format (windows-latest)
  • GitHub Check: build-and-test-e2e-windows / integration-windows-test
  • GitHub Check: build-apple-debug-all / build-macos-debug
🔇 Additional comments (5)
scripts/core-requirements.patch (1)

5-6: Frontend package removal aligns with PR objectives.

The removal of comfyui-frontend-package==1.34.9 and the update to comfyui-workflow-templates==0.7.63 are consistent with the stated approach of managing the frontend version separately while upgrading core dependencies.

assets/requirements/windows_nvidia.compiled (1)

52-71: Dependency updates consistent across Windows variants.

The comfyui package upgrades in the NVIDIA build match those in the CPU build, maintaining consistency across Windows platforms. The same verification regarding beta version stability applies here.

assets/requirements/macos.compiled (2)

47-66: Cross-platform dependency consistency maintained.

The comfyui package upgrades are consistent across all three platform lockfiles (macOS, Windows CPU, Windows NVIDIA), which is essential for maintaining feature parity and reducing platform-specific issues.


1-345: Consider runtime and integration testing beyond static analysis.

The PR description mentions running yarn format, yarn lint, and yarn typescript, but doesn't mention runtime or integration tests. Given the scope of dependency updates (including a beta version), consider:

  1. Running end-to-end tests to verify ComfyUI functionality
  2. Testing on each target platform (macOS, Windows CPU, Windows NVIDIA)
  3. Validating that existing workflows continue to function correctly with the new dependency versions
package.json (1)

18-18: ComfyUI v0.6.0 has been officially released (as of 2025-12-10). The version bump aligns with the PR objectives and targets a valid, publicly available release.

Comment on lines +51 to 70
comfyui-manager==4.0.3b7
# via -r assets/ComfyUI/manager_requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates==0.7.59
comfyui-workflow-templates==0.7.63
# via -r assets/ComfyUI/requirements.txt
# from https://pypi.org/simple
comfyui-workflow-templates-core==0.3.43
comfyui-workflow-templates-core==0.3.58
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-api==0.3.22
comfyui-workflow-templates-media-api==0.3.31
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-image==0.3.36
comfyui-workflow-templates-media-image==0.3.43
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-other==0.3.47
comfyui-workflow-templates-media-other==0.3.61
# via comfyui-workflow-templates
# from https://pypi.org/simple
comfyui-workflow-templates-media-video==0.3.19
comfyui-workflow-templates-media-video==0.3.22
# via comfyui-workflow-templates
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify package versions exist on PyPI and check for security advisories

echo "=== Checking comfyui-manager versions on PyPI ==="
curl -s https://pypi.org/pypi/comfyui-manager/json | jq -r '.releases | keys[]' | grep "4.0.3b7" || echo "Version 4.0.3b7 not found"

echo -e "\n=== Checking comfyui-workflow-templates versions on PyPI ==="
curl -s https://pypi.org/pypi/comfyui-workflow-templates/json | jq -r '.releases | keys[]' | grep "0.7.63" || echo "Version 0.7.63 not found"

echo -e "\n=== Checking comfyui-workflow-templates-core on PyPI ==="
curl -s https://pypi.org/pypi/comfyui-workflow-templates-core/json | jq -r '.releases | keys[]' | grep "0.3.58" || echo "Version 0.3.58 not found"

echo -e "\n=== Checking other workflow-template packages ==="
curl -s https://pypi.org/pypi/comfyui-workflow-templates-media-api/json | jq -r '.releases | keys[]' | grep "0.3.31" || echo "Version 0.3.31 not found"

echo -e "\n=== Checking if packages are stable releases or beta ==="
curl -s https://pypi.org/pypi/comfyui-manager/json | jq '.info | {name, version, release_url, home_page}'

Repository: Comfy-Org/desktop

Length of output: 511


Address beta version in production dependency.

The comfyui-manager==4.0.3b7 is a beta release (stable version 4.0.2 is available) and should not be used in a compiled production requirements file. Beta versions may contain breaking changes, incomplete features, or undiscovered bugs that could destabilize deployments.

Replace 4.0.3b7 with either:

  1. The stable 4.0.2 release, or
  2. Document and justify why the beta version is required over the stable release

All specified package versions are available on PyPI.

🤖 Prompt for AI Agents
assets/requirements/windows_cpu.compiled lines 51-70: the file pins
comfyui-manager to a beta release 4.0.3b7 which is inappropriate for a
production compiled requirements file; update the pinned version to the stable
comfyui-manager==4.0.2 (replace 4.0.3b7) OR add a short adjacent comment
documenting and justifying why the beta is required (include ticket/issue link
and explicit risk acceptance), then regenerate/verify the compiled requirements
to ensure no other transitive pins break.

@benceruleanlu benceruleanlu merged commit f5a69d4 into main Dec 24, 2025
22 of 23 checks passed
@benceruleanlu benceruleanlu deleted the bump/comfyui-0.6.0 branch December 24, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants