Skip to content

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jan 8, 2026

Remove rocm-sdk-devel from AMD ROCm SDK install list.

What changed

  • Drop the rocm_sdk_devel wheel from the AMD ROCm SDK package list used during Windows AMD installs.

Why

  • AMD ROCm installs still pulled rocm-sdk-devel via the SDK install path after it was removed from requirements and the compiled lockfile.
  • This aligns actual install behavior with the intended package set and avoids pulling the devel package.
  • Tradeoff: if any downstream step depended on rocm_sdk_devel being present, it will no longer be available by default.

Evidence

  • Tests: yarn lint, yarn typescript

References

┆Issue is synchronized with this Notion page by Unito

Copilot AI review requested due to automatic review settings January 8, 2026 20:25
@benceruleanlu benceruleanlu requested a review from a team as a code owner January 8, 2026 20:25
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

A single AMD ROCm SDK devel wheel URL entry was removed from the AMD_ROCM_SDK_PACKAGES constant array in src/constants.ts. The constant's export signature and type remain unchanged; only the array contents were modified.

Changes

Cohort / File(s) Summary
AMD ROCm SDK Package Configuration
src/constants.ts
Removed one AMD ROCm SDK devel wheel URL from the AMD_ROCM_SDK_PACKAGES array

Possibly related PRs

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed176e3 and aeb1d23.

📒 Files selected for processing (1)
  • src/constants.ts
💤 Files with no reviewable changes (1)
  • src/constants.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Upload results
  • GitHub Check: lint-and-format (macos-latest)
  • GitHub Check: build-apple-debug-all / build-macos-debug
  • GitHub Check: build-and-test-e2e-windows / integration-windows-test
  • GitHub Check: lint-and-format (windows-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the rocm-sdk-devel package from the AMD ROCm SDK installation list for Windows AMD installs, completing the removal that was started in PR #1511.

Key Changes:

  • Removed the rocm_sdk_devel wheel URL from the AMD_ROCM_SDK_PACKAGES constant in constants.ts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@benceruleanlu benceruleanlu merged commit a414053 into main Jan 8, 2026
22 of 23 checks passed
@benceruleanlu benceruleanlu deleted the chore/remove-rocm-sdk-devel branch January 8, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants