Add dismissible NVIDIA driver warning with versioned suppression

src/install/installationManager.ts

@@ -398,19 +398,28 @@ export class InstallationManager implements HasTelemetry {
     if (process.platform !== 'win32') return;
     if (installation.virtualEnvironment.selectedDevice !== 'nvidia') return;
 
+    const config = useDesktopConfig();
+    if (config.get('suppressNvidiaDriverWarningFor') === NVIDIA_DRIVER_MIN_VERSION) return;
+
     const driverVersion =
       (await this.getNvidiaDriverVersionFromSmi()) ?? (await this.getNvidiaDriverVersionFromSmiFallback());
     if (!driverVersion) return;
 
     if (!isNvidiaDriverBelowMinimum(driverVersion)) return;
 
-    await this.appWindow.showMessageBox({
+    const { checkboxChecked } = await this.appWindow.showMessageBox({
       type: 'warning',
       title: 'Update NVIDIA Driver',
       message: 'Your NVIDIA driver may be too old for PyTorch 2.9.1 + cu130.',
       detail: `Detected driver version: ${driverVersion}\nRecommended minimum: ${NVIDIA_DRIVER_MIN_VERSION}\n\nPlease consider updating your NVIDIA drivers and retrying if you run into issues.`,
       buttons: ['OK'],
+      checkboxLabel: "Don't show again",
+      checkboxChecked: false,
     });
+
+    if (checkboxChecked) {
+      config.set('suppressNvidiaDriverWarningFor', NVIDIA_DRIVER_MIN_VERSION);
+    }
   }
 
   /**

src/store/desktopSettings.ts

@@ -35,4 +35,6 @@ export type DesktopSettings = {
   versionConsentedMetrics?: string;
   /** Whether the user has generated an image successfully. */
   hasGeneratedSuccessfully?: boolean;
+  /** The minimum NVIDIA driver version for which the warning was dismissed. */
+  suppressNvidiaDriverWarningFor?: string;
 };

tests/unit/install/installationManager.test.ts

@@ -33,13 +33,15 @@ vi.mock('node:fs/promises', () => ({
 }));
 
 const config = {
-  get: vi.fn((key: string) => {
+  get: vi.fn((key: string): string | undefined => {
     if (key === 'installState') return 'installed';
     if (key === 'basePath') return 'valid/base';
+    return undefined;
   }),
-  set: vi.fn((key: string, value: string) => {
-    if (key !== 'basePath') throw new Error(`Unexpected key: ${key}`);
-    if (!value) throw new Error(`Unexpected value: [${value}]`);
+  set: vi.fn((key: string, value: unknown) => {
+    const allowedKeys = new Set(['basePath', 'suppressNvidiaDriverWarningFor']);
+    if (!allowedKeys.has(key)) throw new Error(`Unexpected key: ${key}`);
+    if (key === 'basePath' && !value) throw new Error(`Unexpected value: [${value}]`);
   }),
 };
 vi.mock('@/store/desktopConfig', () => ({
@@ -110,6 +112,7 @@ const createMockAppWindow = () => {
     send: vi.fn(),
     loadPage: vi.fn(() => Promise.resolve(null)),
     showOpenDialog: vi.fn(),
+    showMessageBox: vi.fn(() => Promise.resolve({ response: 0, checkboxChecked: false })),
     maximize: vi.fn(),
   };
   return mock as unknown as AppWindow;
@@ -251,6 +254,77 @@ describe('InstallationManager', () => {
       cleanup?.();
     });
   });
+
+  describe('warnIfNvidiaDriverTooOld', () => {
+    const createInstallation = (device: string) =>
+      ({ virtualEnvironment: { selectedDevice: device } }) as ComfyInstallation;
+
+    const getManagerMethods = () =>
+      manager as unknown as {
+        warnIfNvidiaDriverTooOld: (installation: ComfyInstallation) => Promise<void>;
+        getNvidiaDriverVersionFromSmi: () => Promise<string | undefined>;
+        getNvidiaDriverVersionFromSmiFallback: () => Promise<string | undefined>;
+      };
+
+    beforeEach(() => {
+      vi.mocked(config.get).mockImplementation((key: string) => {
+        if (key === 'installState') return 'installed';
+        if (key === 'basePath') return 'valid/base';
+        return undefined;
+      });
+      vi.mocked(config.set).mockClear();
+      vi.mocked(mockAppWindow.showMessageBox).mockClear();
+    });
+
+    it('skips dialog when warning is suppressed for the current minimum version', async () => {
+      const platformSpy = vi.spyOn(process, 'platform', 'get').mockReturnValue('win32');
+      const managerMethods = getManagerMethods();
+      const smiSpy = vi.spyOn(managerMethods, 'getNvidiaDriverVersionFromSmi').mockResolvedValue('570.0');
+      const smiFallbackSpy = vi
+        .spyOn(managerMethods, 'getNvidiaDriverVersionFromSmiFallback')
+        .mockResolvedValue(undefined);
+
+      try {
+        vi.mocked(config.get).mockImplementation((key: string) => {
+          if (key === 'installState') return 'installed';
+          if (key === 'basePath') return 'valid/base';
+          if (key === 'suppressNvidiaDriverWarningFor') return '580';
+          return undefined;
+        });
+
+        await managerMethods.warnIfNvidiaDriverTooOld(createInstallation('nvidia'));
+
+        expect(smiSpy).not.toHaveBeenCalled();
+        expect(smiFallbackSpy).not.toHaveBeenCalled();
+        expect(mockAppWindow.showMessageBox).not.toHaveBeenCalled();
+      } finally {
+        smiSpy.mockRestore();
+        smiFallbackSpy.mockRestore();
+        platformSpy.mockRestore();
+      }
+    });
+
+    it('stores the current minimum version when dismissed', async () => {
+      const platformSpy = vi.spyOn(process, 'platform', 'get').mockReturnValue('win32');
+      const managerMethods = getManagerMethods();
+      const smiSpy = vi.spyOn(managerMethods, 'getNvidiaDriverVersionFromSmi').mockResolvedValue('570.0');
+      const smiFallbackSpy = vi
+        .spyOn(managerMethods, 'getNvidiaDriverVersionFromSmiFallback')
+        .mockResolvedValue(undefined);
+
+      try {
+        vi.mocked(mockAppWindow.showMessageBox).mockResolvedValue({ response: 0, checkboxChecked: true });
+
+        await managerMethods.warnIfNvidiaDriverTooOld(createInstallation('nvidia'));
+
+        expect(config.set).toHaveBeenCalledWith('suppressNvidiaDriverWarningFor', '580');
+      } finally {
+        smiSpy.mockRestore();
+        smiFallbackSpy.mockRestore();
+        platformSpy.mockRestore();
+      }
+    });
+  });
 });
 
 describe('parseNvidiaDriverVersionFromSmiOutput', () => {