Skip to content

Add split typecheck scripts for build and tests #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christian-byrne merged 1 commit into from
Jan 30, 2026
+11 −5
Merged

Add split typecheck scripts for build and tests #1539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
```bash
yarn lint # Check & auto-fix ESLint issues
yarn format # Auto-format code
yarn typescript # TypeScript type checking
yarn typecheck # TypeScript type checking (all)
```

### Development
Expand Down Expand Up @@ -145,7 +145,7 @@ This project must maintain exceptionally high type standards. The `any` type mus
## Before Committing

1. Use `yarn format` to ensure consistent formatting
1. Run `yarn lint` and `yarn typescript` to check code quality
1. Run `yarn lint` and `yarn typecheck` to check code quality
1. Run `yarn test:unit` to ensure unit tests pass
1. Consider running `yarn test:e2e` for UI changes

Expand Down
8 changes: 5 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,12 @@
"test:unit": "vitest run",
"todesktop:afterPack": "./scripts/todesktop/afterPack.cjs",
"todesktop:beforeInstall": "./scripts/todesktop/beforeInstall.cjs",
"typescript": "tsc -p tsconfig.build.json",
"typecheck": "tsc -p tsconfig.json",
"typecheck:build": "tsc -p tsconfig.build.json",
"typecheck:tests": "tsc -p tsconfig.tests.json",
"verify:build": "node scripts/verifyBuild.js",
"vite:compile": "yarn run typescript && vite build && vite build --config vite.preload.config.ts",
"vite:types": "yarn run typescript && vite build --config vite.types.config.ts && node scripts/prepareTypes.js",
"vite:compile": "yarn run typecheck:build && vite build && vite build --config vite.preload.config.ts",
"vite:types": "yarn run typecheck:build && vite build --config vite.types.config.ts && node scripts/prepareTypes.js",
"release:types": "node scripts/releaseTypes.js",
"update:frontend": "node scripts/updateFrontend.js"
},
Expand Down
4 changes: 4 additions & 0 deletions tsconfig.tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"extends": "./tsconfig.json",
"include": ["tests/**/*", "playwright.config.ts", "playwright.setup.ts"]
Copy link

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tsconfig.tests.json includes test files that are already covered by the base tsconfig.json's include patterns (which includes 'tests/**/*'). This creates redundancy since running 'tsc -p tsconfig.json' will already typecheck these files. Consider whether tsconfig.tests.json should exclude non-test files to provide true isolation, or clarify the intended purpose of having separate test typechecking if it's meant to run with different compiler options in the future.

Copilot uses AI. Check for mistakes.
}
Loading