Skip to content

Support Windows machine-scope installs for OEM imaging#1598

Draft
benceruleanlu wants to merge 16 commits intomainfrom
ben/oem-machine-scope-install-state
Draft

Support Windows machine-scope installs for OEM imaging#1598
benceruleanlu wants to merge 16 commits intomainfrom
ben/oem-machine-scope-install-state

Conversation

@benceruleanlu
Copy link
Copy Markdown
Member

@benceruleanlu benceruleanlu commented Feb 9, 2026

Summary

  • support machine-scope Windows installs for OEM and audit-mode imaging flows
  • allow NSIS machine install selection via /INSTALL_SCOPE, /ALLUSERS, /CURRENTUSER, and /OEM
  • default machine installs to a ProgramData base path and harden ACLs on that location
  • persist only machine install state and base path in ProgramData so OOBE-created users can reuse the install
  • hydrate first-launch per-user config from machine install state and recreate per-user extra_models_config.yaml when needed
  • keep uv's Python install under ProgramData for machine-scoped installs

Out of Scope

  • preseed config import
  • shared model-config relocation
  • auto-update policy propagation
  • model or workflow seeding
  • OEM design doc artifacts

Validation

  • yarn format
  • yarn lint
  • yarn typecheck
  • yarn test:unit tests/unit/config/machineConfig.test.ts tests/unit/install/installWizard.test.ts tests/unit/main-process/comfyInstallation.test.ts tests/unit/virtualEnvironment.test.ts tests/unit/config/comfyServerConfig.test.ts

┆Issue is synchronized with this Notion page by Unito

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 9, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 869f7427-f19c-46ef-adf0-0c065b5cfb66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ben/oem-machine-scope-install-state
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@benceruleanlu benceruleanlu changed the title Add machine-scope config hydration for OEM sysprep flows Support Windows machine-scope installs for OEM imaging Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant