Skip to content

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Jun 1, 2025

Don't exit with status code > 0 if grep/diff fails and fix issue described below:

Looking at the debug logs, I can see the issue. The
problem is in the way shell arrays are being used in
GitHub Actions. The main issue is:

  1. Array initialization syntax: Lines like
    MOVED_FILES=() and MISSING_TRANSLATIONS=() work in bash,
    but there are additional issues with how the arrays are
    being handled in the GitHub Actions environment.
  2. The specific error: Looking at the debug logs, I can
    see that the script is failing because when GitHub
    Actions processes the workflow, it's having trouble with
    the double curly braces ${{}} syntax when it's mixed
    with shell array operations.

The issue is that GitHub Actions is trying to evaluate
${{#MISSING_TRANSLATIONS[@]}} as GitHub Actions syntax
rather than shell syntax. Let me fix this:

@christian-byrne christian-byrne changed the title Fix zh check CI workflow failing Fix: Chinese Translation Sync Check always fails Jun 1, 2025
@christian-byrne christian-byrne merged commit 57ad3dc into main Jun 1, 2025
4 checks passed
@christian-byrne christian-byrne deleted the fix-zh-check-ci branch June 1, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants