[fix] Resolve type disparity between SlotShape and RenderShape #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… #931) - Update INodeSlot interface to use SlotShape instead of RenderShape for type safety - Add validateSlotShape() function to handle backward compatibility with legacy workflows - Add runtime validation in addInput()/addOutput() methods to convert invalid shapes - Add migration logic in configure() method for deserializing legacy workflows - Update rendering code to use SlotShape values and provide proper fallbacks - Remove unsafe type assertions that compromised type safety The solution maintains full backward compatibility while fixing the type system to accurately reflect that slots only support a subset of RenderShape values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Comfy-Org/ComfyUI_frontend#4714 - Resolves the type safety issue where
SlotShapeis a subset ofRenderShapebut the type system didn't reflect this properly.Changes
INodeSlot.shapeto useSlotShapeinstead ofRenderShapevalidateSlotShape()function for backward compatibilityaddInput()/addOutput()methodsconfigure()for legacy workflowsSlotShapevaluesBackward Compatibility
The solution maintains full backward compatibility:
RenderShape.ROUNDorRenderShape.CARDare automatically migratedTesting