[subgraph] Extract cycle detection to shared utility and validate on subgraph creation #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create src/subgraph/utils/cycleDetection.ts with validation functions - Add validateNoSubgraphCycles and validateSubgraphAddition utilities - Integrate cycle detection into LGraph.convertToSubgraph() - Add comprehensive tests for cycle detection functionality - Prevent creating subgraphs that would cause infinite recursion
christian-byrne
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
src/subgraph/utils/cycleDetection.tsLGraph.convertToSubgraph()to prevent creating subgraphs that would cause infinite recursionImplementation Details
validateNoSubgraphCycles()- Checks if nodes contain circular references before subgraph creationvalidateSubgraphAddition()- Validates nodes being added to existing subgraphscontainsSubgraph()- Helper function to recursively check subgraph containmentLGraph.convertToSubgraph()at line 1417Test Coverage
test/subgraph/utils/cycleDetection.test.ts)LGraph.convertToSubgraph()(test/LGraph.convertToSubgraph.test.ts)This improvement prevents users from accidentally creating subgraphs that would cause infinite loops during execution by detecting cycles at creation time rather than runtime.