Fix "Dragging from input slot connected to SubgraphInputNode creates new link instead of moving existing one"#1184
Merged
benceruleanlu merged 4 commits intomasterfrom Aug 2, 2025
Merged
Conversation
Contributor
|
Can you resolve conflicts and rebase? BTW you should try making the 2nd PR target the 1st PR, then when the 1st is merged the base branch will be automatically switch for you by GitHub. |
Member
Author
wow never knew that, awesome info |
Contributor
|
|
- Add existingLink tracking to ToInputFromIoNodeLink - Dispatch 'input-moved' event when moving existing links - Use listenUntilReset for deferred disconnect (prevents link loss on cancelled drags) - Update event type definitions to support ToInputFromIoNodeLink This ensures subgraph input links behave consistently with regular node links when dragging. Co-Authored-By: Claude <noreply@anthropic.com>
christian-byrne
force-pushed
the
bl-fix-dragging
branch
from
b5eba75 to
5ba4f07
Compare
christian-byrne
approved these changes
Aug 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds a special check for SUBGRAPH_INPUT_ID because of incompatabilities with it being a virtual node.
maybe we can add a cleaner support for this later, but it does fix the issue for now.
Screen.Recording.2025-08-01.033515.mp4
fixes #1170
also, #1182 might need to go in first, this branched off of that