Skip to content

Conversation

@saqibameen
Copy link
Member

@saqibameen saqibameen commented Mar 7, 2025

Make topK configurable for memory

Testing

  1. Run migration
  2. Create memory, upload docs, go to settings and change topK
  3. Attach memory to pipe and run query
  4. See the augmented chunks in Run

Testing UI memory creation:
1- Test creating new memory in UI
2- Test creating new memory using rag.new
3- Test creating new memory using api endpoint
4- Test creating new memory via SDK

Docs

https://github.com/LangbaseInc/docs/pull/171

Dashboard

https://github.com/LangbaseInc/langbase-dashboard/pull/713

API

https://github.com/LangbaseInc/langbase-api/pull/408

SDK

#89

@saqibameen saqibameen requested a review from ahmadbilaldev March 8, 2025 00:17
Copy link
Contributor

@ahmadbilaldev ahmadbilaldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saqibameen saqibameen merged commit a51eb90 into main Mar 17, 2025
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants