Save Entries Refresh Info Fix #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
PringlesGang
left a comment
PringlesGang
left a comment
There was a problem hiding this comment.
I think you just shouldn't be able to change the CurrentlyFocusedElement as it is saving period. Does an early return in UpdateInput and a guard for SavePages->at(*CurrentPage)->Update(dt) on GetFlag(SF_SAVEICON) or SaveSystem::GetLoadStatus() work as well?
If it doesn't, then this is perfectly fine
Gunoshozo
force-pushed
the
save-entries-refresh-fix
branch
from
85e1c60 to
07c1bbb
Compare
Gunoshozo
force-pushed
the
save-entries-refresh-fix
branch
from
07c1bbb to
e768d4d
Compare
Member
|
Now if you cancel save overwriting it will just freeze up |
Gunoshozo
force-pushed
the
save-entries-refresh-fix
branch
2 times, most recently
from
539edb8 to
a74e9b5
Compare
- Unfocus sysmesbox only when completely hidden - Remove redundant MainItems field
Gunoshozo
force-pushed
the
save-entries-refresh-fix
branch
from
a74e9b5 to
8563242
Compare
Enorovan
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.