-
Notifications
You must be signed in to change notification settings - Fork 128
Add VSCode debugger support for executable Java apps #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -217,7 +217,10 @@ await notificationService.PublishUpdateAsync(javaAppResource, state => state wit | |
private static IResourceBuilder<JavaAppExecutableResource> WithJavaDefaults( | ||
this IResourceBuilder<JavaAppExecutableResource> builder, | ||
JavaAppExecutableResourceOptions options) => | ||
#pragma warning disable ASPIREEXTENSION001 // Type is for evaluation purposes only and is subject to change or removal in future updates | ||
builder.WithOtlpExporter() | ||
.WithEnvironment("JAVA_TOOL_OPTIONS", $"-javaagent:{options.OtelAgentPath?.TrimEnd('/')}/opentelemetry-javaagent.jar") | ||
.WithEnvironment("SERVER_PORT", options.Port.ToString(CultureInfo.InvariantCulture)); | ||
.WithEnvironment("SERVER_PORT", options.Port.ToString(CultureInfo.InvariantCulture)) | ||
.WithVSCodeDebugSupport(builder.Resource.WorkingDirectory, "java", "vscjava.vscode-java-pack"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. New behavior for VS Code Java debugging lacks tests. Please add an xUnit test that exercises a Java app resource configured via WithJavaDefaults and asserts that VS Code debug support metadata/configuration is emitted (e.g., languageId 'java' and the chosen extension ID), following the repo’s testing conventions. Copilot generated this review using guidance from repository custom instructions. Positive FeedbackNegative Feedback |
||
#pragma warning restore ASPIREEXTENSION001 // Type is for evaluation purposes only and is subject to change or removal in future updates | ||
} |
Uh oh!
There was an error while loading. Please reload this page.