Skip to content

Conversation

@adrianhall
Copy link
Collaborator

No description provided.

@adrianhall adrianhall added Client Improvements or additions to the client code Fixed The issue is fixed. labels Apr 4, 2025
@adrianhall adrianhall added this to the 9.0.2 milestone Apr 4, 2025
@adrianhall adrianhall requested a review from Copilot April 4, 2025 15:53
@adrianhall adrianhall self-assigned this Apr 4, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/CommunityToolkit.Datasync.Client/Offline/OperationsQueue/OperationsQueueManager.cs:352

  • Confirm that response.ContentStream is always seekable; if not, this call may throw an exception at runtime.
_ = response.ContentStream.Seek(0L, SeekOrigin.Begin); // Reset the memory stream to the beginning.

src/CommunityToolkit.Datasync.Client/Offline/Operations/PullOperationManager.cs:77

  • [nitpick] Since the condition now accesses metadata.UpdatedAt as a non-nullable value, consider removing the '.Value' accessor for consistency.
lastSynchronization = metadata.UpdatedAt.Value;

@adrianhall adrianhall merged commit 43c654f into CommunityToolkit:main Apr 4, 2025
5 checks passed
@adrianhall adrianhall deleted the issues/298 branch April 4, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client Improvements or additions to the client code Fixed The issue is fixed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant