Skip to content

Conversation

@jcoc611-microsoft
Copy link
Contributor

Before:
Screenshot 2024-11-29 105149

After:
Screenshot 2024-11-29 104946

Improvements:

  • Margins
  • Single Border element for outer lines which makes it possible to have corner radius
  • Header background (default color is lightest accent color, configurable)

@ShankarBUS
Copy link

Hi @jcoc611-microsoft

I have ported MarkdownTextBlock to Uno Platform and made some changes to it for my personal project.

image

https://github.com/symptum/Symptum/blob/dev/src/Symptum.UI/Markdown/TextElements/TableElement.cs

The changes I made include:

  • Removed of MyTableUIElement and used a plain Grid instead.
  • Applying the table border to the cell's grid rather than using a custom panel i.e. MyTableUIElement.
  • CornerRadius for each cell is calculated based on its index.
  • Added support for Grid Tables as well.
  • Rows can be colored alternatively.
  • Used Style instead of Brush, Thickness properties in MarkdownTheme allowing theme-awareness and more customizability.

@Arlodotexe Arlodotexe self-requested a review March 14, 2025 19:53
@Arlodotexe Arlodotexe moved this to 👀 In review in Toolkit 8.x Mar 14, 2025
Copy link
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, I can verify that the expected improvement appears on both Uwp and Wasdk 🎉

image

@Arlodotexe Arlodotexe enabled auto-merge March 14, 2025 19:57
@Arlodotexe Arlodotexe merged commit 186f3d8 into CommunityToolkit:main Mar 14, 2025
21 of 22 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Toolkit 8.x Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants