Skip to content

Fix sudden CI errors #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 25, 2025
Merged

Fix sudden CI errors #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
305af83
Update uno.check version to 1.27.4 and tooling submodule reference
Arlodotexe Jan 24, 2025
ba23199
Treat CS1591 and CS1574 as warnings, not errors
Arlodotexe Jan 24, 2025
ac57120
Update tooling pointer
Arlodotexe Jan 24, 2025
47a3062
Refactor warnings handling and update documentation comments
Arlodotexe Jan 24, 2025
025a077
Update tooling pointer to latest main
Arlodotexe Jan 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"uno.check": {
"version": "1.20.2",
"version": "1.27.4",
"commands": [
"uno-check"
]
Expand Down
8 changes: 7 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,13 @@
<NoWarn>$(NoWarn);Uno0001</NoWarn>

<!-- See https://github.com/CommunityToolkit/Labs-Windows/pull/605#issuecomment-2498743676 -->
<WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904</WarningsNotAsErrors>
<WarningsNotAsErrors>NU1901;NU1902;NU1903;NU1904;</WarningsNotAsErrors>

<!-- Labs only: No error for 'Missing XML comment for publicly visible type or member' -->
<WarningsNotAsErrors>$(WarningsNotAsErrors);CS1591;CS1574;</WarningsNotAsErrors>

<!-- See https://github.com/CommunityToolkit/Windows/pull/609#issuecomment-2613505591 -->
<WarningsNotAsErrors>$(WarningsNotAsErrors);CS0419;CS1570;</WarningsNotAsErrors>
</PropertyGroup>

<Import Project="Windows.Toolkit.Common.props" />
Expand Down
2 changes: 1 addition & 1 deletion components/MarkdownTextBlock/src/TextElements/MyList.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public void AddChild(IAddChild child)

private BulletType ToBulletType(char bullet)
{
/// Gets or sets the type of the bullet (e.g: '1', 'a', 'A', 'i', 'I').
// Gets or sets the type of the bullet (e.g: '1', 'a', 'A', 'i', 'I').
switch (bullet)
{
case '1':
Expand Down
2 changes: 1 addition & 1 deletion components/RivePlayer/src/StateMachineInputCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace CommunityToolkit.Labs.WinUI.Rive;
///
/// <rive:RivePlayer Source="...">
/// <!-- Adds this input to the StateMachineInputCollection. -->
/// <rive:BoolInput Target=... />
/// <rive:BoolInput Target="..." />
/// </rive:RivePlayer>
///
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion tooling
Open in desktop
Submodule tooling updated 5 files
+1 −1 .config/dotnet-tools.json
+1 −1 CommunityToolkit.Tooling.SampleGen.Tests/CommunityToolkit.Tooling.SampleGen.Tests.csproj
+1 −1 CommunityToolkit.Tooling.TestGen.Tests/CommunityToolkit.Tooling.TestGen.Tests.csproj
+1 −1 ProjectHeads/App.Head.Wasm.props
+5 −0 ToolkitComponent.SourceProject.props
Loading