Skip to content

Added key name for the default Shimmer style #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

Added key name for the default Shimmer style #657

merged 2 commits into from
Mar 18, 2025

Conversation

@0x5bfa
Copy link
Contributor

@0x5bfa 0x5bfa commented Mar 14, 2025

As the title

Let me know your thoughts.

@0x5bfa
Update
3f85536 
Revert "Update"

This reverts commit 8c71f09.

Update
@0x5bfa 0x5bfa changed the title Added key name for the default Shimmer style and used GeneratedDependenctProperty for Shimmer Added key name for the default Shimmer style Mar 14, 2025
niels9001
niels9001 approved these changes Mar 15, 2025
View reviewed changes
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arlodotexe Arlodotexe merged commit 77f09b3 into CommunityToolkit:main Mar 18, 2025
22 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-Shimmer branch March 18, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

@niels9001 niels9001 niels9001 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0x5bfa @Arlodotexe @niels9001