Skip to content

[MarkdownTextBlock] Adding Handled property to OnLinkClicked #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
Merged

[MarkdownTextBlock] Adding Handled property to OnLinkClicked #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
adccd6e
Adding Handled property
niels9001 Sep 18, 2025
debd88e
Merge branch 'main' into niels9001/handled
Arlodotexe Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions components/MarkdownTextBlock/src/HtmlWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,13 @@ public static void WriteHtml(WinUIRenderer renderer, HtmlNodeCollection nodes)
var myHyperlinkButton = new MyHyperlinkButton(node, renderer.Config.BaseUrl);
myHyperlinkButton.ClickEvent += (sender, e) =>
{
renderer.MarkdownTextBlock.RaiseLinkClickedEvent(((HyperlinkButton)sender).NavigateUri);
var button = (HyperlinkButton)sender;
var uri = button.NavigateUri;
var handled = renderer.MarkdownTextBlock.RaiseLinkClickedEvent(uri);
if (handled)
{
button.NavigateUri = null;
}
};
hyperLink = myHyperlinkButton;
}
Expand All @@ -45,7 +51,12 @@ public static void WriteHtml(WinUIRenderer renderer, HtmlNodeCollection nodes)
var myHyperlink = new MyHyperlink(node, renderer.Config.BaseUrl);
myHyperlink.ClickEvent += (sender, e) =>
{
renderer.MarkdownTextBlock.RaiseLinkClickedEvent(sender.NavigateUri);
var uri = sender.NavigateUri;
var handled = renderer.MarkdownTextBlock.RaiseLinkClickedEvent(uri);
if (handled)
{
sender.NavigateUri = null;
}
};
hyperLink = myHyperlink;
}
Expand Down
4 changes: 4 additions & 0 deletions components/MarkdownTextBlock/src/LinkClickedEventArgs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ namespace CommunityToolkit.WinUI.Controls;
public class LinkClickedEventArgs : EventArgs
{
public Uri Uri { get; }
/// <summary>
/// Set to true in your handler to indicate the link click was handled and default navigation should be suppressed.
/// </summary>
public bool Handled { get; set; }

public LinkClickedEventArgs(Uri uri)
{
Expand Down
11 changes: 10 additions & 1 deletion components/MarkdownTextBlock/src/MarkdownTextBlock.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,16 @@ public partial class MarkdownTextBlock : Control

public event EventHandler<LinkClickedEventArgs>? OnLinkClicked;

internal void RaiseLinkClickedEvent(Uri uri) => OnLinkClicked?.Invoke(this, new LinkClickedEventArgs(uri));
internal bool RaiseLinkClickedEvent(Uri uri)
{
if (OnLinkClicked == null)
{
return false;
}
var args = new LinkClickedEventArgs(uri);
OnLinkClicked?.Invoke(this, args);
return args.Handled;
}

private static void OnConfigChanged(DependencyObject d, DependencyPropertyChangedEventArgs e)
{
Expand Down
18 changes: 16 additions & 2 deletions components/MarkdownTextBlock/src/Renderers/ObjectRenderers/Inlines/LinkInlineRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,15 @@ protected override void Write(WinUIRenderer renderer, LinkInline link)
var myHyperlinkButton = new MyHyperlinkButton(link, renderer.Config.BaseUrl);
myHyperlinkButton.ClickEvent += (sender, e) =>
{
renderer.MarkdownTextBlock.RaiseLinkClickedEvent(((HyperlinkButton)sender).NavigateUri);
var button = (HyperlinkButton)sender;
var uri = button.NavigateUri;
var handled = renderer.MarkdownTextBlock.RaiseLinkClickedEvent(uri);
if (handled)
{
// Suppress default navigation by clearing NavigateUri just for this invocation
button.NavigateUri = null;
// Optionally restore later; not needed unless reused.
}
};
renderer.Push(myHyperlinkButton);
}
Expand All @@ -42,7 +50,13 @@ protected override void Write(WinUIRenderer renderer, LinkInline link)
var hyperlink = new MyHyperlink(link, renderer.Config.BaseUrl);
hyperlink.ClickEvent += (sender, e) =>
{
renderer.MarkdownTextBlock.RaiseLinkClickedEvent(sender.NavigateUri);
var uri = sender.NavigateUri;
var handled = renderer.MarkdownTextBlock.RaiseLinkClickedEvent(uri);
if (handled)
{
// Suppress navigation by clearing NavigateUri
sender.NavigateUri = null;
}
};

renderer.Push(hyperlink);
Expand Down
Loading