Skip to content

Install .NET 6 SDK to re-enable XAML Styler #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2025
Merged

Install .NET 6 SDK to re-enable XAML Styler #731

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a00644e
Install .NET 6 SDK to enable XAML Styler after removal from
Arlodotexe Sep 19, 2025
e457fe1
Update runner to windows-latest-large for build and package jobs to f…
Arlodotexe Sep 19, 2025
1db66d7
Reset tooling to latest main
Arlodotexe Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ jobs:

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# .NET 6 SDK is required for xamlstyler.console to run.
Copy link
Member

@michael-hawker michael-hawker Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update XAML Styler version instead

- name: Install .NET SDK v6
uses: actions/setup-dotnet@v4
with:
dotnet-version: 6.0.x

- name: Install .NET SDK v${{ env.DOTNET_VERSION }}
uses: actions/setup-dotnet@v4
with:
Expand All @@ -58,7 +64,7 @@ jobs:
# Build both Uno.UI/WinUI2/UWP and Uno.WinUI/WinUI3/WindowsAppSDK versions of our packages using a matrix
build:
needs: [Xaml-Style-Check]
runs-on: windows-latest
runs-on: windows-latest-large

# See https://docs.github.com/actions/using-jobs/using-a-matrix-for-your-jobs
strategy:
Expand Down Expand Up @@ -236,7 +242,7 @@ jobs:
dotnet-dump analyze ${{ steps.filter.outputs.dump_files }} -c "clrstack" -c "pe -lines" -c "exit"

package:
runs-on: windows-latest
runs-on: windows-latest-large
needs: [build]
strategy:
fail-fast: false # prevent one matrix pipeline from being cancelled if one fails, we want them all to run to completion.
Expand Down
Loading