Use PropertyChanging for ShapeBorderThickness range validation

TheCodeTraveler · TheCodeTraveler · commit 4149f2e60721 · 2025-11-24T15:24:17.000-08:00
diff --git a/src/CommunityToolkit.Maui/Views/RatingView/RatingView.shared.cs b/src/CommunityToolkit.Maui/Views/RatingView/RatingView.shared.cs
@@ -69,7 +69,7 @@ public event EventHandler<RatingChangedEventArgs> RatingChanged
 	/// </summary>
 	/// <remarks>A value of 0 indicates that no border will be rendered. Negative values are not supported and may
 	/// result in undefined behavior.</remarks>
-	[BindableProperty(DefaultValue = RatingViewDefaults.ShapeBorderThickness, PropertyChangedMethodName = nameof(OnShapeBorderThicknessChanged))]
+	[BindableProperty(DefaultValue = RatingViewDefaults.ShapeBorderThickness, PropertyChangedMethodName = nameof(OnShapeBorderThicknessChanged), PropertyChangingMethodName = nameof(OnShapeBorderThicknessChanging))]
 	public partial double ShapeBorderThickness { get; set; }
 
 	/// <summary>
@@ -360,13 +360,16 @@ static void OnShapeBorderColorChanged(BindableObject bindable, object oldValue,
 		}
 	}
 
-	static void OnShapeBorderThicknessChanged(BindableObject bindable, object oldValue, object newValue)
+	static void OnShapeBorderThicknessChanging(BindableObject bindable, object oldValue, object newValue)
 	{
 		if ((double)newValue < 0)
 		{
 			throw new ArgumentOutOfRangeException(nameof(newValue), $"{nameof(ShapeBorderThickness)} must be greater than 0");
 		}
+	}
 
+	static void OnShapeBorderThicknessChanged(BindableObject bindable, object oldValue, object newValue)
+	{
 		var ratingView = (RatingView)bindable;
 		for (var element = 0; element < ratingView.RatingLayout.Count; element++)
 		{

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ public event EventHandler<RatingChangedEventArgs> RatingChanged`
`69`	`69`	`/// </summary>`
`70`	`70`	`/// <remarks>A value of 0 indicates that no border will be rendered. Negative values are not supported and may`
`71`	`71`	`/// result in undefined behavior.</remarks>`
`72`		`- [BindableProperty(DefaultValue = RatingViewDefaults.ShapeBorderThickness, PropertyChangedMethodName = nameof(OnShapeBorderThicknessChanged))]`
	`72`	`+ [BindableProperty(DefaultValue = RatingViewDefaults.ShapeBorderThickness, PropertyChangedMethodName = nameof(OnShapeBorderThicknessChanged), PropertyChangingMethodName = nameof(OnShapeBorderThicknessChanging))]`
`73`	`73`	`public partial double ShapeBorderThickness { get; set; }`
`74`	`74`
`75`	`75`	`/// <summary>`
`@@ -360,13 +360,16 @@ static void OnShapeBorderColorChanged(BindableObject bindable, object oldValue,`
`360`	`360`	`}`
`361`	`361`	`}`
`362`	`362`
`363`		`- static void OnShapeBorderThicknessChanged(BindableObject bindable, object oldValue, object newValue)`
	`363`	`+ static void OnShapeBorderThicknessChanging(BindableObject bindable, object oldValue, object newValue)`
`364`	`364`	`{`
`365`	`365`	`if ((double)newValue < 0)`
`366`	`366`	`{`
`367`	`367`	`throw new ArgumentOutOfRangeException(nameof(newValue), $"{nameof(ShapeBorderThickness)} must be greater than 0");`
`368`	`368`	`}`
	`369`	`+ }`
`369`	`370`
	`371`	`+ static void OnShapeBorderThicknessChanged(BindableObject bindable, object oldValue, object newValue)`
	`372`	`+ {`
`370`	`373`	`var ratingView = (RatingView)bindable;`
`371`	`374`	`for (var element = 0; element < ratingView.RatingLayout.Count; element++)`
`372`	`375`	`{`