Android service update #2897
Open
Android service update #2897
+250
−471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored `MediaElement` implementation for Android to replace the bound service (`MediaControlsService`) with `MediaSession` and `MediaController`, simplifying the architecture and aligning with modern Android media playback practices. - Removed `BoundServiceBinder` and `BoundServiceConnection` classes. - Updated `MediaControlsService` to use `ExoPlayer` and `MediaSession`. - Simplified notification management with `NotificationCompat`. - Refactored `MediaManager` to remove session and bound service logic. - Added `CreateMediaController` for asynchronous `MediaController` setup. - Updated `MauiMediaElement` to support `MediaController` integration. - Removed legacy code, unused imports, and redundant methods.
…gating a second time to same item and now the image does display in notifications. It did not previously. This affects load times. It is now faster.
src/CommunityToolkit.Maui.MediaElement/Services/MediaControlsService.android.cs
Outdated
Show resolved
Hide resolved
- Updated `textureview.xml` to use black backgrounds for better consistency. - Replaced `RelativeLayout` with `FrameLayout` in `MauiMediaElement.android.cs` for improved layout management. - Refactored `MediaControlsService.android.cs`: - Replaced `static readonly` fields with `const` for immutability. - Added audio attributes for better playback handling. - Updated track selector to fallback to system language. - Added handling for audio interruptions (e.g., unplugging headphones). - Added `OnTracksChanged` in `MediaManager.android.cs` to manage subtitle button visibility. - Removed unused imports and redundant constants for cleaner code. - Improved buffering strategies for smoother playback.
|
The issue with transparent or white background has been fixed! So this is now ready for review :) |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Android MediaElement implementation by replacing the deprecated service architecture with Google's recommended MediaSessionService approach. The changes migrate from using ExoPlayer directly to using MediaController with MediaSessionService, implementing proper lifecycle management and unified media notifications.
Key changes include:
- Replaced ExoPlayer with MediaController as the platform media element
- Implemented MediaSessionService pattern for background media playback
- Unified media notifications using native Android methods instead of custom implementations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| MediaManager.shared.cs | Updated global using alias from IExoPlayer to MediaController |
| MediaManager.android.cs | Complete overhaul replacing ExoPlayer with MediaController, removed service binding logic |
| MauiMediaElement.android.cs | Refactored layout from RelativeLayout to FrameLayout, added MediaController integration |
| MediaControlsService.android.cs | Converted from Service to MediaSessionService with proper notification handling |
| BoundServiceConnection.android.cs | File deleted - service binding no longer needed |
| BoundServiceBinder.android.cs | File deleted - service binding no longer needed |
| textureview.xml | Changed background colors from white/transparent to black |
| MediaElementHandler.android.cs | Added async MediaController creation and connection logic |
| AppBuilderExtensions.shared.cs | Removed MediaControlsService dependency injection |
src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.android.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Maui.MediaElement/Views/MediaManager.android.cs
Outdated
Show resolved
Hide resolved
…oid.cs Good catch Co-authored-by: Copilot <[email protected]>
…oid.cs Co-authored-by: Copilot <[email protected]>
Updated the CreateMediaController method to include an optional CancellationToken parameter, allowing the operation to be canceled if needed. Modified the WaitAsync call to respect the provided cancellation token, improving the method's flexibility and robustness.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Switch from using default service implementation to using the recommended by Google. Player and
MediaSessioninMediaSessionServicewithMediaControllerin Activity. The deprecated API's for notifications have been completely removed and are no longer needed.No change in features with respect to media notifications. The rich media notifications have been significantly overhauled and following best principles. The issue with notification getting stuck and not being removed when leaving page are fixed. When you stop the player the notifications will be removed automatically. If you navigate away from page the notifications will also be removed. It you force close the app by swiping up it will close the notifications and end playback.
The new changes include using a
MediaControlleras an interface to theMediaSessionServicewhich lives in the Activity and fully replaces the player functionality as far asMediaManageris concerned.Deprecated API's like
PlayerNotificationsand custom http handlers to make web requests to get artwork have been removed and replaced with native methods that do the same thing. The Media Notifications are now unified under a single class and none of the API's are deprecated. This has backwards support and is tested from API 26 to 35.Breaking Changes:
The downside to this is possible a deal breaker and is a breaking change. Currently MediaElement supports as many concurrent players as you the developers chooses to use. With this change it will not longer support this. It will only support a single instance per app. With how the service model and integration between the player, player view and mediaSession works it is not really possible to have more than one Rich Media Session at the same time. Imagine your notification tray having a new item for every video in your collection?
This is a big issue. It is an ongoing issue for Windows, MacOS and iOS. All 3 of those devices have current and ongoing issues with CollectionViews, Grids, and Carousel Views. I do not believe it should ever have been intended to have this functionality and we should work towards creating sample pages where developers can effectively use those views and have a media element. But we need to keep to a single, reusable instance. Having multiple simultaneous players should not be supported and is not needed if the pages are designed correctly.
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information