Skip to content

Fixed gallery crash under Wasdk 1.6 #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Fixed gallery crash under Wasdk 1.6 #214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
485e7ee
Fixed runtime binding exception in wasdk gallery where the generated …
Arlodotexe Sep 16, 2024
76501d0
Expose GeneratedPropertyMetadata as generated type instead of IEnumer…
Arlodotexe Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CommunityToolkit.App.Shared/Renderers/GeneratedSampleOptionsRenderer.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ public GeneratedSampleOptionsRenderer()
/// The backing <see cref="DependencyProperty"/> for <see cref="SampleOptions"/>.
/// </summary>
public static readonly DependencyProperty SampleOptionsProperty =
DependencyProperty.Register(nameof(SampleOptions), typeof(IEnumerable<IGeneratedToolkitSampleOptionViewModel>), typeof(GeneratedSampleOptionsRenderer), new PropertyMetadata(null));
DependencyProperty.Register(nameof(SampleOptions), typeof(List<IGeneratedToolkitSampleOptionViewModel>), typeof(GeneratedSampleOptionsRenderer), new PropertyMetadata(new List<IGeneratedToolkitSampleOptionViewModel>()));

/// <summary>
/// The generated sample options that should be displayed to the user.
/// </summary>
public IEnumerable<IGeneratedToolkitSampleOptionViewModel>? SampleOptions
public List<IGeneratedToolkitSampleOptionViewModel> SampleOptions
{
get => (IEnumerable<IGeneratedToolkitSampleOptionViewModel>?)GetValue(SampleOptionsProperty);
get => (List<IGeneratedToolkitSampleOptionViewModel>)GetValue(SampleOptionsProperty);
set => SetValue(SampleOptionsProperty, value);
}

Expand Down
9 changes: 6 additions & 3 deletions CommunityToolkit.App.Shared/Renderers/ToolkitSampleRenderer.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,13 @@ private async Task LoadData()
// Generated properties reference these in getters and setters.
propertyContainer.GeneratedPropertyMetadata = Metadata.GeneratedSampleOptions;

SampleOptionsPaneInstance = new GeneratedSampleOptionsRenderer
if (propertyContainer.GeneratedPropertyMetadata is not null)
{
SampleOptions = propertyContainer.GeneratedPropertyMetadata
};
SampleOptionsPaneInstance = new GeneratedSampleOptionsRenderer
{
SampleOptions = propertyContainer.GeneratedPropertyMetadata.ToList()
};
}
}
else
{
Expand Down
Loading