Skip to content

MultiTarget updates: Organize GlobalUsings, add HasWinUI2 msbuild property #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 21, 2024
Merged

MultiTarget updates: Organize GlobalUsings, add HasWinUI2 msbuild property #234

merged 7 commits into from
Dec 21, 2024

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Dec 2, 2024 •
edited
Loading

This PR:

  • Organizes our GlobalUsings
    • Cleans up random imports or exclusions
    • Adds a EnableGlobalUsings property (enabled by default)
      • Respects the HasWinUI property when importing GlobalUsings.WinUI.cs.
      • Removes imports in various files that no longer need it
  • Adds a HasWinUI2 property to complement our existing HasWinUI property.
    • Can be used to enable or disable references to Microsoft.UI.Xaml when running under UWP without turning off references to WinUI (wasdk, uno) on other deployable targets.

@Arlodotexe Arlodotexe self-assigned this Dec 2, 2024
@Arlodotexe Arlodotexe requested a review from Sergio0694 December 2, 2024 22:54
@Arlodotexe Arlodotexe marked this pull request as draft December 2, 2024 22:54
@Arlodotexe Arlodotexe changed the title Add HasWinUI2 msbuild property Add HasWinUI2 msbuild property, misc MultiTarget updates Dec 3, 2024
@Arlodotexe Arlodotexe changed the title Add HasWinUI2 msbuild property, misc MultiTarget updates MultiTarget updates: Organize GlobalUsings, add HasWinUI2 msbuild property Dec 3, 2024
@Arlodotexe Arlodotexe marked this pull request as ready for review December 3, 2024 19:31
@Arlodotexe Arlodotexe mentioned this pull request Dec 3, 2024
Closed
@Arlodotexe Arlodotexe mentioned this pull request Dec 20, 2024
Merged
@Arlodotexe Arlodotexe force-pushed the multitarget/haswinui2 branch from 2e56869 to 4d331c6 Compare December 20, 2024 23:39
@Arlodotexe Arlodotexe force-pushed the multitarget/haswinui2 branch from 4d331c6 to 75353f1 Compare December 20, 2024 23:46
@Arlodotexe Arlodotexe enabled auto-merge (rebase) December 20, 2024 23:50
@Arlodotexe Arlodotexe merged commit 83dff9f into main Dec 21, 2024
11 checks passed
@Arlodotexe Arlodotexe deleted the multitarget/haswinui2 branch December 21, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sergio0694 Sergio0694 Sergio0694 approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels

None yet

Projects

Toolkit 8.x
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arlodotexe @Sergio0694