Fix wasdk Sample Gallery not building #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to invalid platform configuration mapping
This was referenced Feb 26, 2025
michael-hawker
approved these changes
Mar 3, 2025
michael-hawker
deleted the
multitarget/wasdk/fix-sln-configuration-mapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Sample Gallery solution in generated in WinUI 3 mode couldn't build the libraries or gallery heads, citing "Current solution contains incorrect configurations mappings."
Issue was fixed by defining the
Platformsproperty for libraries on both UWP and WinUI 3, instead of just UWP. It was presumed (given advice from @Sergio0694 iirc) that the SDK would define this property for us, but the behavior here suggests otherwise and has been corrected.