Initial take on fixing sample app source/package links for Labs experimental components #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
commented
Mar 20, 2025
CommunityToolkit.App.Shared/Renderers/ToolkitDocumentationRenderer.xaml.cs
Outdated
Show resolved
Hide resolved
…imental components See CommunityToolkit/Windows#587 At least in part, there's many inconsistncies in the Labs packages from changes to templates. Both in inclusion of `.Labs.` in package as well as `.Controls.` or not.
michael-hawker
force-pushed
the
llama/fix-587
branch
from
ed21c75 to
fbfe6f9
Compare
20 tasks
Arlodotexe
approved these changes
Apr 1, 2025
There was a problem hiding this comment.
Approved to keep things moving for 8.2 stable release.
I'll want to make a light note for later; in this PR we've hardcoded something we also have declared in MSBuild (PackageIdPrefix). Someday we may want to consolidate and connect the logic to make this more reusable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CommunityToolkit/Windows#587
At least in part, there's many inconsistencies in the Labs packages from changes to templates. Both in inclusion of
.Labs.in package as well as.Controls.or not.Something we should fix in the Labs repo so everything is consistent with how the packages are named (between source, csproj props, and nuget packages).
That will make some of this code obsolete, but should just work, so we can commit here and fix in Labs after so the sample app can be correctly pointing to all packages.
(Note it's hard to copy labs components into the main repo, and vice-versa due to dependencies. We need a method in labs where we reference toolkit components differently so we can just assign properties for project reference vs. package reference, etc... [There may be an issue for that already?])