Only include heads for requested MultiTargets if Components that use them were included #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them were included
Arlodotexe
added a commit
to CommunityToolkit/Labs-Windows
that referenced
this pull request
May 13, 2025
Arlodotexe
added
bug 🐛
|
Validated in CommunityToolkit/Labs-Windows#674 |
michael-hawker
pushed a commit
to CommunityToolkit/Labs-Windows
that referenced
this pull request
May 13, 2025
michael-hawker
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #281 and CommunityToolkit/Labs-Windows#647
Uncovered in a CI run for CommunityToolkit/Labs-Windows#674, the WASM build will fail in incremental CI runs where the components changed don't support wasm, such as with MarkdownTextBlock.
The error manifests as
The name 'ToolkitSampleRegistry' does not exist in the current context, which happens when no components were found by the source generator. In this case, the MultiTarget system correctly prevented the improper import.The fix is to adjust solution generation so that Gallery heads designed to run a specific MultiTarget are only included in the solution if a component with that MultiTarget was also included.
This way, if no requested components support the available heads (wasm, uwp, wasdk), those heads aren't included in the generated solution.