Skip to content

Fixed issue with IncrementalLoadingCollection within AdvancedCollecti… #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed issue with IncrementalLoadingCollection within AdvancedCollecti… #643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb7aebd
Fixed issue with IncrementalLoadingCollection within AdvancedCollecti…
Feb 24, 2025
c6f687a
Instead of using first object type, added if clause to detect Increme…
Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/Collections/src/AdvancedCollectionView/AdvancedCollectionView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// See the LICENSE file in the project root for more information.

using CommunityToolkit.WinUI.Helpers;
using System;
using System.CodeDom;
using System.Collections;
using System.Collections.Specialized;
using System.Runtime.CompilerServices;
Expand Down Expand Up @@ -388,7 +390,11 @@ int IComparer<object>.Compare(object x, object y)
var listType = _source?.GetType();
Type type;

if (listType != null && listType.IsGenericType)
if (listType == typeof(IncrementalLoadingCollection))
{
type = listType.GetGenericArguments()[1];
}
else if (listType != null && listType.IsGenericType)
{
type = listType.GetGenericArguments()[0];
}
Expand Down