Skip to content

Fix WrapPanel stretching behavior for last item #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix WrapPanel stretching behavior for last item #704

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5072d89
Fix WrapPanel stretching behavior for last item
AndrewKeepCoding Jul 17, 2025
cece15f
Add a page with a WrapPanel to fix tests with dynamic XAML loading
AndrewKeepCoding Jul 18, 2025
121a7e3
Add WrapPanel infinity test case
AndrewKeepCoding Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/Primitives/src/WrapPanel/WrapPanel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,8 @@ void Arrange(UIElement child, bool isLast = false)
}

// Stretch the last item to fill the available space
if (isLast)
// if the parent measure is not infinite
if (isLast && double.IsInfinity(parentMeasure.U) is false)
Copy link
Preview

Copilot AI Jul 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using 'is false' pattern is less readable than the negation operator. Consider using '!double.IsInfinity(parentMeasure.U)' for better readability and consistency with common C# practices.

Suggested change
if (isLast && double.IsInfinity(parentMeasure.U) is false)
if (isLast && !double.IsInfinity(parentMeasure.U))

Copilot uses AI. Check for mistakes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I accidentally hit this button... interesting.

{
desiredMeasure.U = parentMeasure.U - position.U;
}
Expand Down
Loading